Run APK tests on the android_test trybot.

Run APK tests on the android_test trybot.

Test failures are ignored for now.

TBR=mark@chromium.org,tsepez@chromium.org
BUG=125059
TEST=

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=137352

[Yaron, 2012-05-15 01:57:38]

http://codereview.chromium.org/10387086/diff/8004/build/android/buildbot_func...
File build/android/buildbot_functions.sh (right):

http://codereview.chromium.org/10387086/diff/8004/build/android/buildbot_func...
build/android/buildbot_functions.sh:197: function
bb_native_test_compile_run_tests {
What happens with this?

http://codereview.chromium.org/10387086/diff/8004/testing/android/AndroidMani...
File testing/android/AndroidManifest.xml (left):

http://codereview.chromium.org/10387086/diff/8004/testing/android/AndroidMani...
testing/android/AndroidManifest.xml:13: <uses-sdk android:minSdkVersion="15" />
I thought we use 15 elsewhere (i.e. ant build files)

[Yaron, 2012-05-15 02:28:16]

lgtm

[nilesh, 2012-05-15 02:29:18]

http://codereview.chromium.org/10387086/diff/8004/build/android/buildbot_func...
File build/android/buildbot_functions.sh (right):

http://codereview.chromium.org/10387086/diff/8004/build/android/buildbot_func...
build/android/buildbot_functions.sh:197: function
bb_native_test_compile_run_tests {
On 2012/05/15 01:57:38, Yaron wrote:
> What happens with this?

We still need this step.

http://codereview.chromium.org/10387086/diff/8004/testing/android/AndroidMani...
File testing/android/AndroidManifest.xml (left):

http://codereview.chromium.org/10387086/diff/8004/testing/android/AndroidMani...
testing/android/AndroidManifest.xml:13: <uses-sdk android:minSdkVersion="15" />
On 2012/05/15 01:57:38, Yaron wrote:
> I thought we use 15 elsewhere (i.e. ant build files)

No, 15 wont install on some devices.

[John Grabowski, 2012-05-15 22:24:39]

http://codereview.chromium.org/10387086/diff/8004/build/android/buildbot_func...
File build/android/buildbot_functions.sh (right):

http://codereview.chromium.org/10387086/diff/8004/build/android/buildbot_func...
build/android/buildbot_functions.sh:212: echo "@@@STEP_WARNINGS@@@"
looks like this is missing a "rm -f $tempfile"
can you add it?

http://codereview.chromium.org/10387086/diff/8004/build/android/buildbot_func...
build/android/buildbot_functions.sh:253: fi
rm -f $tempfile
but...

refactor so we have a bb_run_tests_internal that takes an arg and is used by
both bb_run_apk_tests and bb_blah...

http://codereview.chromium.org/10387086/diff/8004/build/android/buildbot_func...
build/android/buildbot_functions.sh:254: }
delete $tempfile when done

http://codereview.chromium.org/10387086/diff/8004/build/android/buildbot_try_...
File build/android/buildbot_try_compile_test.sh (right):

http://codereview.chromium.org/10387086/diff/8004/build/android/buildbot_try_...
build/android/buildbot_try_compile_test.sh:20: bb_run_apk_tests
hmm... don't we need a regyp/recompile?

http://codereview.chromium.org/10387086/diff/8004/testing/android/AndroidMani...
File testing/android/AndroidManifest.xml (left):

http://codereview.chromium.org/10387086/diff/8004/testing/android/AndroidMani...
testing/android/AndroidManifest.xml:13: <uses-sdk android:minSdkVersion="15" />
On 2012/05/15 02:29:18, nileshagrawal1 wrote:
> On 2012/05/15 01:57:38, Yaron wrote:
> > I thought we use 15 elsewhere (i.e. ant build files)
> 
> No, 15 wont install on some devices.

Which devices?
I agree with Yaron; I thought we were going to try and use 15 everywhere.

[nilesh, 2012-05-15 22:59:25]

PTAL.

http://codereview.chromium.org/10387086/diff/8004/build/android/buildbot_func...
File build/android/buildbot_functions.sh (right):

http://codereview.chromium.org/10387086/diff/8004/build/android/buildbot_func...
build/android/buildbot_functions.sh:212: echo "@@@STEP_WARNINGS@@@"
On 2012/05/15 22:24:39, John Grabowski wrote:
> looks like this is missing a "rm -f $tempfile"
> can you add it?

Done.

http://codereview.chromium.org/10387086/diff/8004/build/android/buildbot_func...
build/android/buildbot_functions.sh:253: fi
On 2012/05/15 22:24:39, John Grabowski wrote:
> rm -f $tempfile
> but...
> 
> refactor so we have a bb_run_tests_internal that takes an arg and is used by
> both bb_run_apk_tests and bb_blah...

I have not removed the run_tests.py step from bb_native_test_compile_run_tests
I am now running replaceme-debug.apk as part of running the test bundles.

http://codereview.chromium.org/10387086/diff/8004/build/android/buildbot_func...
build/android/buildbot_functions.sh:254: }
On 2012/05/15 22:24:39, John Grabowski wrote:
> delete $tempfile when done

Done.

http://codereview.chromium.org/10387086/diff/8004/build/android/buildbot_try_...
File build/android/buildbot_try_compile_test.sh (right):

http://codereview.chromium.org/10387086/diff/8004/build/android/buildbot_try_...
build/android/buildbot_try_compile_test.sh:20: bb_run_apk_tests
On 2012/05/15 22:24:39, John Grabowski wrote:
> hmm... don't we need a regyp/recompile?

regyp and compile in done in the previous step.

http://codereview.chromium.org/10387086/diff/8004/testing/android/AndroidMani...
File testing/android/AndroidManifest.xml (left):

http://codereview.chromium.org/10387086/diff/8004/testing/android/AndroidMani...
testing/android/AndroidManifest.xml:13: <uses-sdk android:minSdkVersion="15" />
On 2012/05/15 22:24:39, John Grabowski wrote:
> On 2012/05/15 02:29:18, nileshagrawal1 wrote:
> > On 2012/05/15 01:57:38, Yaron wrote:
> > > I thought we use 15 elsewhere (i.e. ant build files)
> > 
> > No, 15 wont install on some devices.
> 
> Which devices?
> I agree with Yaron; I thought we were going to try and use 15 everywhere.
> 

ICS devices. 15 will work ICE_CREAM_SANDWICH_MR1 onwards.
14 is what Chrome.apk and ContentShell.apk use.

[John Grabowski, 2012-05-15 23:06:31]

http://codereview.chromium.org/10387086/diff/8004/build/android/buildbot_func...
File build/android/buildbot_functions.sh (right):

http://codereview.chromium.org/10387086/diff/8004/build/android/buildbot_func...
build/android/buildbot_functions.sh:253: fi
On 2012/05/15 22:59:25, nileshagrawal1 wrote:
> On 2012/05/15 22:24:39, John Grabowski wrote:
> > rm -f $tempfile
> > but...
> > 
> > refactor so we have a bb_run_tests_internal that takes an arg and is used by
> > both bb_run_apk_tests and bb_blah...
> 
> I have not removed the run_tests.py step from bb_native_test_compile_run_tests
> I am now running replaceme-debug.apk as part of running the test bundles.

Yes.  What I meant was, you did some cut and paste then changed 12 chars (added
--apk=True).  Instead, create a new function that takes an arg.  Call that new
function from both here and from the original test function.  Avoid dup.

http://codereview.chromium.org/10387086/diff/8004/build/android/buildbot_try_...
File build/android/buildbot_try_compile_test.sh (right):

http://codereview.chromium.org/10387086/diff/8004/build/android/buildbot_try_...
build/android/buildbot_try_compile_test.sh:20: bb_run_apk_tests
On 2012/05/15 22:59:25, nileshagrawal1 wrote:
> On 2012/05/15 22:24:39, John Grabowski wrote:
> > hmm... don't we need a regyp/recompile?
> 
> regyp and compile in done in the previous step.

Fix naming to be more clear.
Else it is mysterious.
Recommend replacing "native" with "apk", and splitting
bb_native_test_compile_run_tests into a few entry points, like
bb_regyp_apk_test
bb_compile
bb_run_apk_test

[John Grabowski, 2012-05-15 23:50:28]

LGTM with verbal agreement on naming

http://codereview.chromium.org/10387086/diff/17/build/android/buildbot_functi...
File build/android/buildbot_functions.sh (right):

http://codereview.chromium.org/10387086/diff/17/build/android/buildbot_functi...
build/android/buildbot_functions.sh:233: function bb_run_apk_tests {
how about apk_test_run to be consistewnt

http://codereview.chromium.org/10387086/diff/17/build/android/buildbot_try_co...
File build/android/buildbot_try_compile_test.sh (right):

http://codereview.chromium.org/10387086/diff/17/build/android/buildbot_try_co...
build/android/buildbot_try_compile_test.sh:19: bb_apk_test_compile
ditto on naming

http://codereview.chromium.org/10387086/diff/17/build/android/run_tests.py
File build/android/run_tests.py (right):

http://codereview.chromium.org/10387086/diff/17/build/android/run_tests.py#ne...
build/android/run_tests.py:81: _APK_TEST_SUITES = ['replaceme',  # Test the
template apk too.
u rool

[nilesh, 2012-05-16 00:02:05]

All done.

http://codereview.chromium.org/10387086/diff/17/build/android/buildbot_functi...
File build/android/buildbot_functions.sh (right):

http://codereview.chromium.org/10387086/diff/17/build/android/buildbot_functi...
build/android/buildbot_functions.sh:233: function bb_run_apk_tests {
On 2012/05/15 23:50:28, John Grabowski wrote:
> how about apk_test_run to be consistewnt

Done.

http://codereview.chromium.org/10387086/diff/17/build/android/buildbot_try_co...
File build/android/buildbot_try_compile_test.sh (right):

http://codereview.chromium.org/10387086/diff/17/build/android/buildbot_try_co...
build/android/buildbot_try_compile_test.sh:19: bb_apk_test_compile
On 2012/05/15 23:50:28, John Grabowski wrote:
> ditto on naming

Done.

[commit-bot: I haz the power, 2012-05-16 00:12:56]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nileshagrawal@chromium.org/10387086/14004

[commit-bot: I haz the power, 2012-05-16 03:46:42]

Change committed as 137352