Support optional arguments in SendRequestNatives::StartRequest

content/public/renderer/v8_value_converter.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_PUBLIC_RENDERER_V8_VALUE_CONVERTER_H_
 #define CONTENT_PUBLIC_RENDERER_V8_VALUE_CONVERTER_H_
 
 #include "content/common/content_export.h"
 #include "v8/include/v8.h"
 
@@ skipping 10 matching lines @@
 // The JSON types (null, boolean, string, number, array, and object) as well as
 // binary values are supported. For binary values, we convert to WebKit
 // ArrayBuffers, and support converting from an ArrayBuffer or any of the
 // ArrayBufferView subclasses (Uint8Array, etc.).
 class CONTENT_EXPORT V8ValueConverter {
  public:
   static V8ValueConverter* create();
 
   virtual ~V8ValueConverter() {}
 
+  // Use the following setters to support additional types other than the
+  // default ones.
+  virtual bool IsAllowIndefined() const = 0;

[asargent_no_longer_on_chrome, 2012/05/10 20:17:08]

Indefined -> Undefined

Also, "IsAllow" sounds very strange (in conversation, you'd say "is undefined
allowed?" and not "is allow undefined?"). My preference would be to name the
getter just "AllowUndefined". 

similar issue for for IsAllowDate and IsAllowRegexp.

[battre, 2012/05/11 12:16:28]

Done.

+  virtual void SetAllowUndefined(bool val) = 0;
+
+  virtual bool IsAllowDate() const = 0;
+  virtual void SetAllowDate(bool val) = 0;
+
+  virtual bool IsAllowRegexp() const = 0;
+  virtual void SetAllowRegexp(bool val) = 0;
+
   // Converts Value to v8::Value. Unsupported types are replaced with null.
   // If an array or object throws while setting a value, that property or item
   // is skipped, leaving a hole in the case of arrays.
   virtual v8::Handle<v8::Value> ToV8Value(
       const base::Value* value,
       v8::Handle<v8::Context> context) const = 0;
 
   // Converts v8::Value to Value. Unsupported types are replaced with null.
   // If an array or object throws while getting a value, that property or item
   // is replaced with null.
   virtual base::Value* FromV8Value(v8::Handle<v8::Value> value,
                                    v8::Handle<v8::Context> context) const = 0;
 };
 
 }  // namespace content
 
 #endif  // CONTENT_PUBLIC_RENDERER_V8_VALUE_CONVERTER_H_