Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 10387037: Complete rewrite of isolate.py to be more modular. (Closed)

Created:
8 years, 7 months ago by M-A Ruel
Modified:
8 years, 7 months ago
CC:
chromium-reviews, pam+watch_chromium.org, csharp
Visibility:
Public.

Description

Complete rewrite of isolate.py to be more modular. Use an OO approach to store the state. Make the code clearer. 1. Remove 'variables' from foo.result and create foo.state for less important state. 2. Store and manage the file paths in native os.path.sep. Simplify the whole code. 3. Remove the requirement of providing a .isolate file to isolate.py when providing an existing .result file. Make it reuse the result file's data as needed, simplifying user's life. R=nsylvain@chromium.org BUG=98637 TEST=manually ran all the tests on linux and windows Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=136111

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+562 lines, -382 lines) Patch
M tools/isolate/isolate.py View 10 chunks +447 lines, -285 lines 0 comments Download
M tools/isolate/isolate_smoke_test.py View 19 chunks +67 lines, -41 lines 0 comments Download
M tools/isolate/isolate_test.py View 3 chunks +48 lines, -56 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
M-A Ruel
Sorry for the heavy CL.
8 years, 7 months ago (2012-05-09 15:00:44 UTC) #1
nsylvain
Looking at the diff is not really useful, mainly that I'm not super familiar with ...
8 years, 7 months ago (2012-05-09 16:59:51 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/10387037/1
8 years, 7 months ago (2012-05-09 17:02:40 UTC) #3
commit-bot: I haz the power
8 years, 7 months ago (2012-05-09 20:18:59 UTC) #4
Change committed as 136111

Powered by Google App Engine
This is Rietveld 408576698