A better fix for scaling issue.

A better fix for scaling issue.
Instead of using TLS and static function, pass scaling in the skia dictionary.

BUG=125499
TEST=Make sure printing is working.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=136055

[Albert Bodenhamer, 2012-05-08 18:20:42]

LGTM
Nice cleanup.  I like this solution MUCH better.

[gene, 2012-05-08 18:22:36]

Adding brettw for PPAPI

[commit-bot: I haz the power, 2012-05-08 18:22:53]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gene@chromium.org/10387022/1

[commit-bot: I haz the power, 2012-05-08 18:23:00]

Presubmit check for 10387022-1 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    webkit/plugins/ppapi

Presubmit checks took 1.8s to calculate.

[vandebo (ex-Chrome), 2012-05-08 18:25:01]

LGTM with nits.

https://chromiumcodereview.appspot.com/10387022/diff/1/chrome/renderer/print_...
File chrome/renderer/print_web_view_helper_win.cc (left):

https://chromiumcodereview.appspot.com/10387022/diff/1/chrome/renderer/print_...
chrome/renderer/print_web_view_helper_win.cc:127: // TODO(gene): We should
revisit this solution for the next versions.
It might be good to leave this TODO.  Making the scale factor explicit in the
flow might be generally beneficial.

https://chromiumcodereview.appspot.com/10387022/diff/1/chrome/renderer/print_...
File chrome/renderer/print_web_view_helper_win.cc (right):

https://chromiumcodereview.appspot.com/10387022/diff/1/chrome/renderer/print_...
chrome/renderer/print_web_view_helper_win.cc:262: actual_shrink)) {
nit: argument alignment

[brettw, 2012-05-08 18:34:40]

ppapi lgtm rubberstamp

[gene, 2012-05-08 18:34:52]

https://chromiumcodereview.appspot.com/10387022/diff/1/chrome/renderer/print_...
File chrome/renderer/print_web_view_helper_win.cc (left):

https://chromiumcodereview.appspot.com/10387022/diff/1/chrome/renderer/print_...
chrome/renderer/print_web_view_helper_win.cc:127: // TODO(gene): We should
revisit this solution for the next versions.
Done.
Moved next to the code where we retrieve scale factor.

https://chromiumcodereview.appspot.com/10387022/diff/1/chrome/renderer/print_...
File chrome/renderer/print_web_view_helper_win.cc (right):

https://chromiumcodereview.appspot.com/10387022/diff/1/chrome/renderer/print_...
chrome/renderer/print_web_view_helper_win.cc:262: actual_shrink)) {
Moved both on the next line. Aligning |actual_shrink| with *canvas pushed to 81
char line :(.

[vandebo (ex-Chrome), 2012-05-08 18:46:20]

https://chromiumcodereview.appspot.com/10387022/diff/8002/chrome/renderer/pri...
File chrome/renderer/print_web_view_helper_win.cc (right):

https://chromiumcodereview.appspot.com/10387022/diff/8002/chrome/renderer/pri...
chrome/renderer/print_web_view_helper_win.cc:265: *canvas, actual_shrink)) {
nit: this should be four spaces (further) in

[gene, 2012-05-08 18:48:02]

https://chromiumcodereview.appspot.com/10387022/diff/8002/chrome/renderer/pri...
File chrome/renderer/print_web_view_helper_win.cc (right):

https://chromiumcodereview.appspot.com/10387022/diff/8002/chrome/renderer/pri...
chrome/renderer/print_web_view_helper_win.cc:265: *canvas, actual_shrink)) {
On 2012/05/08 18:46:20, vandebo wrote:
> nit: this should be four spaces (further) in 

Done.

[vandebo (ex-Chrome), 2012-05-08 18:48:54]

LGTM

[commit-bot: I haz the power, 2012-05-08 18:52:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gene@chromium.org/10387022/5003

[commit-bot: I haz the power, 2012-05-08 23:43:53]

Try job failure for 10387022-5003 (retry) (retry) (retry) on win_rel for step
"update" (clobber build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

Step "update" is always a major failure.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2012-05-09 00:04:46]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gene@chromium.org/10387022/5003

[commit-bot: I haz the power, 2012-05-09 03:51:37]

Try job failure for 10387022-5003 (previous was lost) (retry) on win_rel for
step "browser_tests".
It's a second try, previously, step "browser_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2012-05-09 04:21:10]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gene@chromium.org/10387022/5003

[commit-bot: I haz the power, 2012-05-09 04:30:15]

Try job failure for 10387022-5003 on win_rel for step "update".
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

Step "update" is always a major failure.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2012-05-09 04:49:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gene@chromium.org/10387022/5003

[commit-bot: I haz the power, 2012-05-09 07:32:51]

Try job failure for 10387022-5003 (retry) on win_rel for step "browser_tests".
It's a second try, previously, step "browser_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2012-05-09 15:32:07]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gene@chromium.org/10387022/5003

[commit-bot: I haz the power, 2012-05-09 17:22:23]

Change committed as 136055