Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1263)

Unified Diff: chrome/browser/ui/webui/about_ui.cc

Issue 10387010: Select theme resources from ResourceBundle at requested scale factor. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Merge with master. Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/about_ui.cc
diff --git a/chrome/browser/ui/webui/about_ui.cc b/chrome/browser/ui/webui/about_ui.cc
index d1df59a823e53d677278fa2e2b0b3af5b9827130..2a0895e25fd3bfc98d073004114b1b57536855f9 100644
--- a/chrome/browser/ui/webui/about_ui.cc
+++ b/chrome/browser/ui/webui/about_ui.cc
@@ -65,6 +65,7 @@
#include "net/base/escape.h"
#include "net/base/net_util.h"
#include "ui/base/l10n/l10n_util.h"
+#include "ui/base/layout.h"
#include "ui/base/resource/resource_bundle.h"
#include "v8/include/v8.h"
#include "webkit/glue/user_agent.h"
@@ -72,8 +73,8 @@
#include "webkit/plugins/webplugininfo.h"
#if defined(OS_LINUX) || defined(OS_OPENBSD)
-#include "content/public/common/sandbox_linux.h"
#include "content/public/browser/zygote_host_linux.h"
+#include "content/public/common/sandbox_linux.h"
#endif
#if defined(OS_WIN)
@@ -246,7 +247,7 @@ class ChromeOSTermsHandler
// Do nothing if OEM EULA load failed.
if (contents_.empty() && path_ != chrome::kOemEulaURLPath) {
contents_ = ResourceBundle::GetSharedInstance().GetRawDataResource(
- IDR_TERMS_HTML).as_string();
+ IDR_TERMS_HTML, ui::SCALE_FACTOR_NONE).as_string();
}
source_->FinishDataRequest(contents_, request_id_);
}
@@ -837,7 +838,8 @@ void FinishMemoryDataRequest(const std::string& path,
source->FinishDataRequest(
ResourceBundle::GetSharedInstance().GetRawDataResource(
path == kMemoryJsPath ? IDR_ABOUT_MEMORY_JS :
- IDR_ABOUT_MEMORY_HTML).as_string(), request_id);
+ IDR_ABOUT_MEMORY_HTML,
+ ui::SCALE_FACTOR_NONE).as_string(), request_id);
}
}
@@ -988,8 +990,8 @@ std::string AboutStats(const std::string& query) {
} else {
// Get about_stats.html/js from resource bundle.
data = ResourceBundle::GetSharedInstance().GetRawDataResource(
- (query == kStatsJsPath ? IDR_ABOUT_STATS_JS : IDR_ABOUT_STATS_HTML)).
- as_string();
+ (query == kStatsJsPath ? IDR_ABOUT_STATS_JS : IDR_ABOUT_STATS_HTML),
+ ui::SCALE_FACTOR_NONE).as_string();
if (query != kStatsJsPath) {
// Clear the timer list since we stored the data in the timers list
@@ -1084,7 +1086,7 @@ std::string AboutVersionStaticContent(const std::string& query) {
return ResourceBundle::GetSharedInstance().GetRawDataResource(
query == kVersionJsPath ?
IDR_ABOUT_VERSION_JS :
- IDR_ABOUT_VERSION_HTML).as_string();
+ IDR_ABOUT_VERSION_HTML, ui::SCALE_FACTOR_NONE).as_string();
}
std::string AboutVersionStrings(DictionaryValue* localized_strings,
@@ -1385,7 +1387,7 @@ void AboutUIHTMLSource::StartDataRequest(const std::string& path,
} else if (host == chrome::kChromeUICreditsHost) {
int idr = (path == kCreditsJsPath) ? IDR_CREDITS_JS : IDR_CREDITS_HTML;
response = ResourceBundle::GetSharedInstance().GetRawDataResource(
- idr).as_string();
+ idr, ui::SCALE_FACTOR_NONE).as_string();
#if defined(OS_CHROMEOS)
} else if (host == chrome::kChromeUICryptohomeHost) {
FinishCryptohomeDataRequest(this, path, request_id);
@@ -1416,7 +1418,7 @@ void AboutUIHTMLSource::StartDataRequest(const std::string& path,
response = AboutNetwork(path);
} else if (host == chrome::kChromeUIOSCreditsHost) {
response = ResourceBundle::GetSharedInstance().GetRawDataResource(
- IDR_OS_CREDITS_HTML).as_string();
+ IDR_OS_CREDITS_HTML, ui::SCALE_FACTOR_NONE).as_string();
#endif
#if defined(OS_LINUX) || defined(OS_OPENBSD)
} else if (host == chrome::kChromeUISandboxHost) {
@@ -1430,7 +1432,7 @@ void AboutUIHTMLSource::StartDataRequest(const std::string& path,
return;
#else
response = ResourceBundle::GetSharedInstance().GetRawDataResource(
- IDR_TERMS_HTML).as_string();
+ IDR_TERMS_HTML, ui::SCALE_FACTOR_NONE).as_string();
#endif
} else if (host == chrome::kChromeUIVersionHost) {
if (path == kStringsJsPath) {

Powered by Google App Engine
This is Rietveld 408576698