Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 10386222: Use ScopedTempDir instead of DIR_TEST_DATA for creating test data. (Closed)

Created:
8 years, 7 months ago by Scott Hess - ex-Googler
Modified:
8 years, 7 months ago
Reviewers:
stuartmorgan, M-A Ruel
CC:
chromium-reviews, dhollowa+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Use ScopedTempDir instead of DIR_TEST_DATA for creating test data. BUG=125513 TEST=git status Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=138071

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -50 lines) Patch
M chrome/browser/password_manager/login_database_unittest.cc View 2 chunks +4 lines, -10 lines 0 comments Download
M chrome/browser/webdata/autofill_table_unittest.cc View 3 chunks +4 lines, -10 lines 0 comments Download
M chrome/browser/webdata/keyword_table_unittest.cc View 2 chunks +4 lines, -10 lines 0 comments Download
M chrome/browser/webdata/token_service_table_unittest.cc View 2 chunks +4 lines, -10 lines 0 comments Download
M chrome/browser/webdata/web_apps_table_unittest.cc View 2 chunks +4 lines, -10 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Scott Hess - ex-Googler
8 years, 7 months ago (2012-05-18 21:03:57 UTC) #1
M-A Ruel
<Virtual hug> lgtm
8 years, 7 months ago (2012-05-20 02:28:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shess@chromium.org/10386222/1
8 years, 7 months ago (2012-05-20 22:03:41 UTC) #3
commit-bot: I haz the power
8 years, 7 months ago (2012-05-20 23:12:58 UTC) #4
Change committed as 138071

Powered by Google App Engine
This is Rietveld 408576698