Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10386221: Cleanup: Remove unneeded scoped_ptr.h includes from chrome/browser. (Closed)

Created:
8 years, 7 months ago by Lei Zhang
Modified:
8 years, 7 months ago
Reviewers:
Nico
CC:
chromium-reviews, Ilya Sherman, creis+watch_chromium.org, nkostylev+watch_chromium.org, rdsmith+dwatch_chromium.org, dhollowa+watch_chromium.org, ajwong+watch_chromium.org, kkania, MAD, cbentzel+watch_chromium.org, robertshield, dyu1, brettw-cc_chromium.org, Avi (use Gerrit), darin-cc_chromium.org, James Su, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, jar (doing other things)
Visibility:
Public.

Description

Cleanup: Remove unneeded scoped_ptr.h includes from chrome/browser. BUG=none TEST=none TBR=owners Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=139172

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -29 lines) Patch
M chrome/browser/autocomplete/autocomplete_popup_model.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autofill/phone_field.h View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/automation/automation_event_observers.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/browsing_data_appcache_helper.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/browsing_data_database_helper.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/browsing_data_file_system_helper.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/browsing_data_indexed_db_helper.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/browsing_data_local_storage_helper.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/browsing_data_quota_helper_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/options/wimax_config_view.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/download/download_service.h View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/history/thumbnail_database.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/infobars/infobar.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/managed_mode.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/metrics/thread_watcher.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/mock_browsing_data_indexed_db_helper.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/net/crl_set_fetcher.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/notifications/desktop_notification_service.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/predictors/autocomplete_action_predictor.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/prefs/command_line_pref_store.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/prefs/scoped_user_pref_update.h View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/prefs/testing_pref_store.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/prefs/testing_pref_store.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/tab_contents/spellchecker_submenu_observer.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/web_resource/notification_promo.h View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Lei Zhang
Also rubberstampable.
8 years, 7 months ago (2012-05-18 23:12:07 UTC) #1
Lei Zhang
ping
8 years, 7 months ago (2012-05-21 23:11:11 UTC) #2
Nico
lgtm
8 years, 7 months ago (2012-05-21 23:18:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/10386221/11005
8 years, 7 months ago (2012-05-25 22:36:44 UTC) #4
commit-bot: I haz the power
Presubmit check for 10386221-11005 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 7 months ago (2012-05-25 22:37:12 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/10386221/11005
8 years, 7 months ago (2012-05-25 22:44:12 UTC) #6
commit-bot: I haz the power
8 years, 7 months ago (2012-05-26 01:06:08 UTC) #7 
Change committed as 139172

Powered by Google App Engine
This is Rietveld 408576698