Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Issue 10386220: Add instantiation declarations for PointBase, SizeBase, RectBase (Closed)

Created:
8 years, 7 months ago by Nico
Modified:
8 years, 7 months ago
Reviewers:
oshima, sky
CC:
chromium-reviews, ncarter (slow), sadrul, akalin, jochen+watch-content_chromium.org, ben+watch_chromium.org, Raghu Simha, jam, penghuang+watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, grt+watch_chromium.org, pam+watch_chromium.org, James Su, tim (not reviewing), yusukes+watch_chromium.org
Visibility:
Public.

Description

Add instantiation declarations for PointBase, SizeBase, RectBase These templates have explicit instantiations in point.cc, point_f.cc, size.cc, size_f.cc, rect.cc, rect_f.cc. This suggests that the intent was to have these instantiations in a single translation unit. Without an explicit instantiation declaration, they would still be weakly emitted to all translation units that use point.h (etc). Add an explicit instantiation declaration to stop this from happening. Thanks to Rafael Espindola for help with this patch. BUG=90078 TEST=do a components debug build on mac. observe fewer linker errors. Normal builds get a bit faster too. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=138012

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : not for msvc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -0 lines) Patch
M ui/gfx/point.h View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M ui/gfx/point_f.h View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M ui/gfx/rect.h View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M ui/gfx/rect_f.h View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M ui/gfx/size.h View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M ui/gfx/size_f.h View 1 2 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Nico
8 years, 7 months ago (2012-05-18 20:16:35 UTC) #1
Nico
8 years, 7 months ago (2012-05-18 20:18:47 UTC) #2
Nico
(Looks like rietveld didn't send the first mail? sky, oshima: Please click through for the ...
8 years, 7 months ago (2012-05-18 20:20:47 UTC) #3
sky
LGTM
8 years, 7 months ago (2012-05-18 21:55:04 UTC) #4
oshima
LGTM On 2012/05/18 20:20:47, Nico wrote: > (Looks like rietveld didn't send the first mail? ...
8 years, 7 months ago (2012-05-18 21:56:51 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/10386220/2001
8 years, 7 months ago (2012-05-18 22:06:39 UTC) #6
commit-bot: I haz the power
Try job failure for 10386220-2001 on win for step "update". http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number=12280 Step "update" is always ...
8 years, 7 months ago (2012-05-18 22:35:46 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/10386220/2001
8 years, 7 months ago (2012-05-18 22:40:20 UTC) #8
commit-bot: I haz the power
Try job failure for 10386220-2001 (retry) on win for step "compile" (clobber build). It's a ...
8 years, 7 months ago (2012-05-18 23:14:19 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/10386220/8004
8 years, 7 months ago (2012-05-18 23:33:04 UTC) #10
commit-bot: I haz the power
8 years, 7 months ago (2012-05-19 02:12:07 UTC) #11
Change committed as 138012

Powered by Google App Engine
This is Rietveld 408576698