Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 10386219: Rename the screenshot file again, much more friendly. (Closed)

Created:
8 years, 7 months ago by Jun Mukai
Modified:
8 years, 7 months ago
Reviewers:
Daniel Erat, sky
CC:
chromium-reviews, sadrul, ben+watch_chromium.org, rkc
Visibility:
Public.

Description

Rename the screenshot file again, much more friendly. The new file names would be formatted as: Screenshot 2012-05-18 1:02:03 PM.png BUG=126603 TEST=manually Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=137964

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M chrome/browser/ui/views/ash/screenshot_taker.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/feedback_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/feedback_ui_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Jun Mukai
8 years, 7 months ago (2012-05-18 19:29:13 UTC) #1
Daniel Erat
LGTM after one issue is addressed. https://chromiumcodereview.appspot.com/10386219/diff/1/chrome/browser/ui/views/ash/screenshot_taker.cc File chrome/browser/ui/views/ash/screenshot_taker.cc (right): https://chromiumcodereview.appspot.com/10386219/diff/1/chrome/browser/ui/views/ash/screenshot_taker.cc#newcode59 chrome/browser/ui/views/ash/screenshot_taker.cc:59: "%d:%02d:%02d.png", now.hour, now.minute, ...
8 years, 7 months ago (2012-05-18 19:32:50 UTC) #2
sky
LGTM
8 years, 7 months ago (2012-05-18 19:56:16 UTC) #3
Jun Mukai
http://codereview.chromium.org/10386219/diff/1/chrome/browser/ui/views/ash/screenshot_taker.cc File chrome/browser/ui/views/ash/screenshot_taker.cc (right): http://codereview.chromium.org/10386219/diff/1/chrome/browser/ui/views/ash/screenshot_taker.cc#newcode59 chrome/browser/ui/views/ash/screenshot_taker.cc:59: "%d:%02d:%02d.png", now.hour, now.minute, now.second)); On 2012/05/18 19:32:51, Daniel Erat ...
8 years, 7 months ago (2012-05-18 20:21:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mukai@chromium.org/10386219/5001
8 years, 7 months ago (2012-05-18 20:22:05 UTC) #5
commit-bot: I haz the power
8 years, 7 months ago (2012-05-18 21:33:31 UTC) #6
Change committed as 137964

Powered by Google App Engine
This is Rietveld 408576698