mac gcapi: Add LaunchGoogleChrome() function.

mac gcapi: Add LaunchGoogleChrome() function.

BUG=128462
TEST=none

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=137921

[Mark Mentovai, 2012-05-18 19:15:06]

LGTM

https://chromiumcodereview.appspot.com/10386218/diff/2001/chrome/installer/gc...
File chrome/installer/gcapi_mac/gcapi.h (right):

https://chromiumcodereview.appspot.com/10386218/diff/2001/chrome/installer/gc...
chrome/installer/gcapi_mac/gcapi.h:34: // This function launches Google Chrome
after a successful install.
I guess this can be done after the “install” part is written, but…

…it might be useful to have the “install” function return a handle (via some
opaque type) that can then be passed to the “launch” function. This could help
the “launch” function find the copy of Chrome that was just installed.

https://chromiumcodereview.appspot.com/10386218/diff/2001/chrome/installer/gc...
File chrome/installer/gcapi_mac/gcapi.mm (right):

https://chromiumcodereview.appspot.com/10386218/diff/2001/chrome/installer/gc...
chrome/installer/gcapi_mac/gcapi.mm:127: @autoreleasepool {
You used an explicit NSAutoreleasePool in GoogleChromeCompatibilityCheck, but
@autoreleasepool here. Does @autoreleasepool work as far back as 10.5 at
runtime?

[Nico, 2012-05-18 19:21:24]

Thanks!

https://chromiumcodereview.appspot.com/10386218/diff/2001/chrome/installer/gc...
File chrome/installer/gcapi_mac/gcapi.h (right):

https://chromiumcodereview.appspot.com/10386218/diff/2001/chrome/installer/gc...
chrome/installer/gcapi_mac/gcapi.h:34: // This function launches Google Chrome
after a successful install.
On 2012/05/18 19:15:06, Mark Mentovai wrote:
> I guess this can be done after the “install” part is written, but…
> 
> …it might be useful to have the “install” function return a handle (via some
> opaque type) that can then be passed to the “launch” function. This could
help
> the “launch” function find the copy of Chrome that was just installed.

This is an excellent suggestion, wil do.

https://chromiumcodereview.appspot.com/10386218/diff/2001/chrome/installer/gc...
File chrome/installer/gcapi_mac/gcapi.mm (right):

https://chromiumcodereview.appspot.com/10386218/diff/2001/chrome/installer/gc...
chrome/installer/gcapi_mac/gcapi.mm:127: @autoreleasepool {
On 2012/05/18 19:15:06, Mark Mentovai wrote:
> You used an explicit NSAutoreleasePool in GoogleChromeCompatibilityCheck, but
> @autoreleasepool here.

In GCCC, @autoreleasepool would indent the whole function and it doesn't help
much. Here I'd have to add a `int result = ` variable so that i can drain before
returning, so it's more useful in this function.

> Does @autoreleasepool work as far back as 10.5 at runtime?

As far as I understand, @autoreleasepool is just compiled into normal
NSAutoreleasePool calls when building without -fobjc-arc. I checked that a
simple test program using @autoreleasepool runs fine on 10.5. (arc does need
some support functions, but i believe those are statically linked into the
resulting binary, so even with arc it should run fine on 10.5. I haven't checked
that part though.)