Issue 10386213: Add command line flags for compositor's default tile size and

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10386213: Add command line flags for compositor's default tile size and (Closed)

Created:
8 years, 7 months ago by Vangelis Kokkevis

Modified:
8 years, 7 months ago

Reviewers:
vangelis, darin (slow to review)

CC:
chromium-reviews, joi+watch-content_chromium.org, jam, darin-cc_chromium.org, jochen+watch-content_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Add command line flags for compositor's default tile size and max untiled layer size. BUG=128740 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=137983

Patch Set 1 #

Total comments: 3

Patch Set 2 : #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+58 lines, -1 line)			Patch
M	content/browser/web_contents/web_contents_impl.cc	View	1	2 chunks	+25 lines, -0 lines	0 comments	Download
M	content/common/view_messages.h	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	content/public/common/content_switches.h	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	content/public/common/content_switches.cc	View	1	1 chunk	+8 lines, -0 lines	0 comments	Download
M	webkit/glue/webpreferences.h	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
M	webkit/glue/webpreferences.cc	View	1	4 chunks	+12 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

darin (slow to review)

8 years, 7 months ago (2012-05-18 20:20:17 UTC) #2

LGTM

https://chromiumcodereview.appspot.com/10386213/diff/1/content/browser/web_co...
File content/browser/web_contents/web_contents_impl.cc (right):

https://chromiumcodereview.appspot.com/10386213/diff/1/content/browser/web_co...
content/browser/web_contents/web_contents_impl.cc:232: int GetSwitchValueInt(
nit: GetSwitchValueInt -> GetSwitchValueAsInt

https://chromiumcodereview.appspot.com/10386213/diff/1/content/browser/web_co...
content/browser/web_contents/web_contents_impl.cc:236: int int_value;
nit: initialize int_value?  or, check the return value of StringToInt.

https://chromiumcodereview.appspot.com/10386213/diff/1/content/browser/web_co...
content/browser/web_contents/web_contents_impl.cc:549: 1,
GetSwitchValueInt(command_line, switches::kDefaultTileWidth));
nit: maybe the lower bound value should just be a parameter to
GetSwitchValueAsInt?

Expand Messages | Collapse Messages