Issue 10386212: Add new attention state to launcher

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10386212: Add new attention state to launcher (Closed)

Created:
8 years, 7 months ago by DaveMoore

Modified:
8 years, 7 months ago

Reviewers:
sky

CC:
chromium-reviews, sadrul, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add new attention state to launcher BUG=119965 TEST=LauncherViewTest.LauncherItemStatus Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=137878

Patch Set 1 #

Total comments: 5

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+97 lines, -18 lines)			Patch
M	ash/launcher/launcher_button.h	View	3 chunks	+7 lines, -5 lines	0 comments	Download
M	ash/launcher/launcher_button.cc	View	7 chunks	+52 lines, -12 lines	5 comments	Download
M	ash/launcher/launcher_types.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	ash/launcher/launcher_view.cc	View	1 chunk	+8 lines, -0 lines	0 comments	Download
M	ash/launcher/launcher_view_unittest.cc	View	2 chunks	+24 lines, -0 lines	0 comments	Download
M	ui/base/animation/tween.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	ui/base/animation/tween.cc	View	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

sky

8 years, 7 months ago (2012-05-18 16:38:30 UTC) #2

LGTM

https://chromiumcodereview.appspot.com/10386212/diff/1/ash/launcher/launcher_...
File ash/launcher/launcher_button.cc (right):

https://chromiumcodereview.appspot.com/10386212/diff/1/ash/launcher/launcher_...
ash/launcher/launcher_button.cc:48: BarView() : animation_(new
ui::ThrobAnimation(this)) {
ALLOW_THIS_IN_INITIALIAZER_LIST

https://chromiumcodereview.appspot.com/10386212/diff/1/ash/launcher/launcher_...
ash/launcher/launcher_button.cc:59: void OnPaint(gfx::Canvas* canvas) {
virtual OVERRIDE

https://chromiumcodereview.appspot.com/10386212/diff/1/ash/launcher/launcher_...
ash/launcher/launcher_button.cc:71: void AnimationProgressed(const
ui::Animation* animation) {
virtual OVERRIDE

https://chromiumcodereview.appspot.com/10386212/diff/1/ash/launcher/launcher_...
ash/launcher/launcher_button.cc:83: scoped_ptr<ui::ThrobAnimation> animation_;
Since you create this in the constructor, no need to use scoped_ptr, make it a
value.

https://chromiumcodereview.appspot.com/10386212/diff/1/ash/launcher/launcher_...
ash/launcher/launcher_button.cc:84: };
DISALLOW_...

Expand Messages | Collapse Messages