Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(601)

Issue 10386192: Add Freqiency column for wifi in about:network (Closed)

Created:
8 years, 7 months ago by stevenjb
Modified:
8 years, 7 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Add Freqiency column for wifi in about:network BUG=none TEST=Go to about:network, Frequency column should exist for wifi networks. TBR=jhawkins Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=137705

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M chrome/browser/ui/webui/about_ui.cc View 2 chunks +2 lines, -0 lines 1 comment Download

Messages

Total messages: 8 (0 generated)
stevenjb
8 years, 7 months ago (2012-05-17 17:14:44 UTC) #1
Greg Spencer (Chromium)
lgtm
8 years, 7 months ago (2012-05-17 17:15:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stevenjb@chromium.org/10386192/1
8 years, 7 months ago (2012-05-17 17:31:26 UTC) #3
commit-bot: I haz the power
Presubmit check for 10386192-1 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 7 months ago (2012-05-17 17:31:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stevenjb@chromium.org/10386192/1
8 years, 7 months ago (2012-05-17 17:33:12 UTC) #5
Paul Stewart
http://codereview.chromium.org/10386192/diff/1/chrome/browser/ui/webui/about_ui.cc File chrome/browser/ui/webui/about_ui.cc (right): http://codereview.chromium.org/10386192/diff/1/chrome/browser/ui/webui/about_ui.cc#newcode372 chrome/browser/ui/webui/about_ui.cc:372: str += WrapWithTH("Frequency"); If you're still not submitted, I'd ...
8 years, 7 months ago (2012-05-17 19:19:22 UTC) #6
commit-bot: I haz the power
Change committed as 137705
8 years, 7 months ago (2012-05-17 19:26:55 UTC) #7
stevenjb
8 years, 7 months ago (2012-05-17 19:27:42 UTC) #8
Next time :)

On 2012/05/17 19:19:22, Paul Stewart wrote:
>
http://codereview.chromium.org/10386192/diff/1/chrome/browser/ui/webui/about_...
> File chrome/browser/ui/webui/about_ui.cc (right):
> 
>
http://codereview.chromium.org/10386192/diff/1/chrome/browser/ui/webui/about_...
> chrome/browser/ui/webui/about_ui.cc:372: str += WrapWithTH("Frequency");
> If you're still not submitted, I'd lobby for this being at the beginning of
> these 4 entries, so that this column is logically next to "strength".  Not a
big
> deal though.

Powered by Google App Engine
This is Rietveld 408576698