Issue 10386185: Add trace events to measure GPU process startup timing and time to first present.

Issue 10386185: Add trace events to measure GPU process startup timing and time to first present. (Closed)

Created:
8 years, 7 months ago by apatrick_chromium

Modified:
8 years, 7 months ago

Reviewers:
piman

CC:
chromium-reviews, jochen+watch-content_chromium.org, dhollowa+watch_chromium.org, jam, apatrick_chromium, joi+watch-content_chromium.org, darin-cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Add trace events to measure GPU process startup timing and time to first present. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=137802

Patch Set 2 : #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+128 lines, -47 lines)			Patch
M	content/browser/gpu/gpu_process_host.cc	View		10 chunks	+17 lines, -10 lines	0 comments	Download
M	content/common/gpu/client/gpu_channel_host.cc	View		4 chunks	+10 lines, -0 lines	0 comments	Download
M	content/common/gpu/gpu_channel.cc	View	1	4 chunks	+8 lines, -2 lines	0 comments	Download
M	content/gpu/gpu_info_collector_linux.cc	View		2 chunks	+3 lines, -0 lines	0 comments	Download
M	content/gpu/gpu_info_collector_mac.mm	View		2 chunks	+3 lines, -0 lines	0 comments	Download
M	content/gpu/gpu_info_collector_win.cc	View		8 chunks	+15 lines, -0 lines	0 comments	Download
M	content/gpu/gpu_main.cc	View		4 chunks	+51 lines, -24 lines	0 comments	Download
M	content/renderer/render_thread_impl.cc	View		2 chunks	+7 lines, -0 lines	0 comments	Download
M	ui/gl/gl_surface.cc	View		2 chunks	+3 lines, -0 lines	0 comments	Download
M	ui/surface/accelerated_surface_win.cc	View		10 chunks	+11 lines, -11 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

piman

LGTM. Moar trace events +1 https://chromiumcodereview.appspot.com/10386185/diff/13/content/common/gpu/gpu_channel.cc File content/common/gpu/gpu_channel.cc (right): https://chromiumcodereview.appspot.com/10386185/diff/13/content/common/gpu/gpu_channel.cc#newcode386 content/common/gpu/gpu_channel.cc:386: #if defined(ENABLE_GPU) nit: Just ...

8 years, 7 months ago (2012-05-17 22:30:03 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/apatrick@chromium.org/10386185/9007

8 years, 7 months ago (2012-05-17 22:37:55 UTC) #3

commit-bot: I haz the power

Try job failure for 10386185-9007 (retry) on linux_chromeos for step "compile" (clobber build). It's a ...

8 years, 7 months ago (2012-05-17 23:03:14 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/apatrick@chromium.org/10386185/9007

8 years, 7 months ago (2012-05-18 01:04:25 UTC) #5

Change committed as 137802

Expand Messages | Collapse Messages