Fix remoting_unittests compilation with aura

Fix remoting_unittests compilation in aura builds.

Moved gtk-dependent code to files with _gtk suffix that are
excluded when compiling without GTK. Also some minor cleanups in remoting.gyp.

BUG=114211
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=137610

[Wez, 2012-05-16 22:28:31]

lgtm

http://codereview.chromium.org/10386181/diff/5001/remoting/remoting.gyp
File remoting/remoting.gyp (right):

http://codereview.chromium.org/10386181/diff/5001/remoting/remoting.gyp#newco...
remoting/remoting.gyp:1220: ['OS=="linux" and chromeos==0', {
nit: Add a comment explaining this combination; given this looks to be
GTK-related, why are we changing it to be CrOS-dependent?

[Sergey Ulanov, 2012-05-16 23:00:06]

http://codereview.chromium.org/10386181/diff/5001/remoting/remoting.gyp
File remoting/remoting.gyp (right):

http://codereview.chromium.org/10386181/diff/5001/remoting/remoting.gyp#newco...
remoting/remoting.gyp:1220: ['OS=="linux" and chromeos==0', {
On 2012/05/16 22:28:32, Wez wrote:
> nit: Add a comment explaining this combination; given this looks to be
> GTK-related, why are we changing it to be CrOS-dependent?

This condition enables compilation of XServerPixelBuffer which is not related to
GTK in any way. In this same time it adds GTK dependency.
Updated it to split into two conditions, one for GTK and one for X11 (OS=linux).

[Wez, 2012-05-16 23:03:26]

lgtm

http://codereview.chromium.org/10386181/diff/9001/remoting/remoting.gyp
File remoting/remoting.gyp (right):

http://codereview.chromium.org/10386181/diff/9001/remoting/remoting.gyp#newco...
remoting/remoting.gyp:1221: 'sources': [
nit: I think it's preferred that all sources be included, and then things
excluded if necessary.  Or we could just give these files a _linux suffix?

[Sergey Ulanov, 2012-05-16 23:10:52]

http://codereview.chromium.org/10386181/diff/9001/remoting/remoting.gyp
File remoting/remoting.gyp (right):

http://codereview.chromium.org/10386181/diff/9001/remoting/remoting.gyp#newco...
remoting/remoting.gyp:1221: 'sources': [
On 2012/05/16 23:03:27, Wez wrote:
> nit: I think it's preferred that all sources be included, and then things
> excluded if necessary.  Or we could just give these files a _linux suffix?

Done.

[Wez, 2012-05-16 23:18:23]

LGTM - Hat-trick!

[commit-bot: I haz the power, 2012-05-17 00:02:52]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sergeyu@chromium.org/10386181/12002

[commit-bot: I haz the power, 2012-05-17 01:59:16]

Change committed as 137610