Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10386178: ash: Add a heads-up display to track touch-point states and positions. (Closed)

Created:
8 years, 7 months ago by sadrul
Modified:
8 years, 7 months ago
CC:
chromium-reviews, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

ash: Add a heads-up display to track touch-point states and positions. The command-line flag to turn on the HUD is --ash-touch-hud. It can also be turned on from about:flags BUG=none TEST=manually Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=137549 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=137605

Patch Set 1 #

Patch Set 2 : . #

Total comments: 2

Patch Set 3 : . #

Patch Set 4 : fix-incognito #

Patch Set 5 : fix clang/win-aura #

Unified diffs Side-by-side diffs Delta from patch set Stats (+208 lines, -3 lines) Patch
M ash/ash.gyp View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M ash/ash_switches.h View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M ash/ash_switches.cc View 1 2 3 4 1 chunk +3 lines, -0 lines 0 comments Download
M ash/shell.h View 2 chunks +5 lines, -0 lines 0 comments Download
M ash/shell.cc View 1 2 4 chunks +10 lines, -2 lines 0 comments Download
A ash/touch/touch_observer_hud.h View 1 2 1 chunk +59 lines, -0 lines 0 comments Download
A ash/touch/touch_observer_hud.cc View 1 2 3 4 1 chunk +112 lines, -0 lines 0 comments Download
M chrome/app/generated_resources.grd View 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 2 3 4 1 chunk +8 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/login_utils.cc View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
sadrul
8 years, 7 months ago (2012-05-16 20:05:24 UTC) #1
Ben Goodger (Google)
http://codereview.chromium.org/10386178/diff/1011/ash/shell.cc File ash/shell.cc (right): http://codereview.chromium.org/10386178/diff/1011/ash/shell.cc#newcode697 ash/shell.cc:697: touch_observer_hud_->Initialize(); instead of having an init method, why not ...
8 years, 7 months ago (2012-05-16 20:14:35 UTC) #2
sadrul
http://codereview.chromium.org/10386178/diff/1011/ash/shell.cc File ash/shell.cc (right): http://codereview.chromium.org/10386178/diff/1011/ash/shell.cc#newcode697 ash/shell.cc:697: touch_observer_hud_->Initialize(); On 2012/05/16 20:14:35, Ben Goodger (Google) wrote: > ...
8 years, 7 months ago (2012-05-16 20:35:55 UTC) #3
Ben Goodger (Google)
8 years, 7 months ago (2012-05-16 20:51:03 UTC) #4 
lgtm

Powered by Google App Engine
This is Rietveld 408576698