Implemented declarative redirects to transparent image and empty document.

Implemented declarative redirects to transparent image and empty document.


BUG=112155
TEST=no


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=137858

[battre, 2012-05-16 17:22:15]

Please review.

Thanks,
Dominic

[Matt Perry, 2012-05-16 23:54:10]

lgtm

on naming: should we call it "ReplaceWithTransparentImage" instead, or do you
prefer to explicitly state that we're doing redirect behind the scenes?

https://chromiumcodereview.appspot.com/10386172/diff/14/chrome/browser/extens...
File chrome/browser/extensions/api/declarative_webrequest/webrequest_action.cc
(right):

https://chromiumcodereview.appspot.com/10386172/diff/14/chrome/browser/extens...
chrome/browser/extensions/api/declarative_webrequest/webrequest_action.cc:216:
if (!(request_stage & GetStages()))
seems like all the CreateDeltas have this check. Can it be moved to a shared
location (i.e. the calling code)?

[battre, 2012-05-18 10:29:38]

I prefer to keep the current naming because we have to explain, which actions
can be used at which URLRequest stages. I.e. you cannot redirect to a
transparent image, based on the incoming response headers.

https://chromiumcodereview.appspot.com/10386172/diff/14/chrome/browser/extens...
File chrome/browser/extensions/api/declarative_webrequest/webrequest_action.cc
(right):

https://chromiumcodereview.appspot.com/10386172/diff/14/chrome/browser/extens...
chrome/browser/extensions/api/declarative_webrequest/webrequest_action.cc:216:
if (!(request_stage & GetStages()))
On 2012/05/16 23:54:12, Matt Perry wrote:
> seems like all the CreateDeltas have this check. Can it be moved to a shared
> location (i.e. the calling code)?

I do this at the caller already. I have replaced these checks with CHECK()s.

[commit-bot: I haz the power, 2012-05-18 11:00:33]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/battre@chromium.org/10386172/13001

[commit-bot: I haz the power, 2012-05-18 11:43:06]

Try job failure for 10386172-13001 (retry) on mac_rel for step "browser_tests".
It's a second try, previously, step "browser_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[commit-bot: I haz the power, 2012-05-18 13:01:40]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/battre@chromium.org/10386172/8005

[commit-bot: I haz the power, 2012-05-18 14:26:46]

Change committed as 137858