Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10386168: Fix a leak in JSONParser::Parse when using hidden root optimizations. (Closed)

Created:
8 years, 7 months ago by Robert Sesek
Modified:
8 years, 7 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews, erikwright (departed), brettw-cc_chromium.org
Visibility:
Public.

Description

Fix a leak in JSONParser::Parse when using hidden root optimizations. BUG=121469 TEST=Valgrind base_unittests TBR=mark@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=137447

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M base/json/json_parser.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Robert Sesek
The hidden roots Swap() the other Value, rather than taking ownership.
8 years, 7 months ago (2012-05-16 17:06:21 UTC) #1
Mark Mentovai
8 years, 7 months ago (2012-05-16 17:30:16 UTC) #2 
LGTM

Powered by Google App Engine
This is Rietveld 408576698