Always do DelegateExecute handler COM registration and make set dual mode prop on shortcuts.

Always do DelegateExecute handler COM registration and make set dual mode prop on shortcuts.

This is in support of the pre-win8 -> win8 upgrade scenario.

BUG=128131, 127734
TEST=manual: install on pre-win8 and confirm that the COM registration for the DelegateExecute handler is present in HKCR (Google Chrome: {5C65F4B0-3651-4514-B207-D10CB699B14B} or Chromium: {A2DF06F9-A21A-44A8-8A99-8B9C84F29160}) and that the start menu shortcut has the dual mode juju.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=137863

[gab, 2012-05-16 17:04:22]

lg, comments below.

https://chromiumcodereview.appspot.com/10386167/diff/1/base/file_util_win.cc
File base/file_util_win.cc (left):

https://chromiumcodereview.appspot.com/10386167/diff/1/base/file_util_win.cc#...
base/file_util_win.cc:419: base::win::GetVersion() >= base::win::VERSION_WIN7) {
You probably also want to get rid of this to support Vista/XP --> Win8.

https://chromiumcodereview.appspot.com/10386167/diff/1/base/win/win_util.cc
File base/win/win_util.cc (left):

https://chromiumcodereview.appspot.com/10386167/diff/1/base/win/win_util.cc#o...
base/win/win_util.cc:197: PKEY_AppUserModel_DualMode,
While you are touching this code it might be good to also remove the temporary
win8 hack I put while we were waiting for win8_sdk to be checked in.

http://code.google.com/searchframe#OAMlx_jo-ck/src/base/win/win_util.cc&exact...

I'm more than happy to do that in a separate change though, but I was planning
to do it as part of this change.

[grt (UTC plus 2), 2012-05-16 17:16:15]

Thanks.

https://chromiumcodereview.appspot.com/10386167/diff/1/base/file_util_win.cc
File base/file_util_win.cc (left):

https://chromiumcodereview.appspot.com/10386167/diff/1/base/file_util_win.cc#...
base/file_util_win.cc:419: base::win::GetVersion() >= base::win::VERSION_WIN7) {
On 2012/05/16 17:04:22, gab wrote:
> You probably also want to get rid of this to support Vista/XP --> Win8.

Excellent point.  I've changed it to >= VERSION_VISTA since IPropertyStore
didn't exist in XP.

https://chromiumcodereview.appspot.com/10386167/diff/1/base/win/win_util.cc
File base/win/win_util.cc (left):

https://chromiumcodereview.appspot.com/10386167/diff/1/base/win/win_util.cc#o...
base/win/win_util.cc:197: PKEY_AppUserModel_DualMode,
On 2012/05/16 17:04:22, gab wrote:
> While you are touching this code it might be good to also remove the temporary
> win8 hack I put while we were waiting for win8_sdk to be checked in.
> 
>
http://code.google.com/searchframe#OAMlx_jo-ck/src/base/win/win_util.cc&exact...
> 
> I'm more than happy to do that in a separate change though, but I was planning
> to do it as part of this change.

We're still compiling against the win7 SDK, so the hack needs to stay for the
time being.

[gab, 2012-05-16 17:29:11]

LGTM

We probably want to add a comment to the shortcut bug saying that this will not
support the XP-->Win8 upgrade (maybe we can do this as part of our magic
first-win8-boot steps though).

[grt (UTC plus 2), 2012-05-16 19:04:10]

i had to back out the vista change.  IPropertyStore::Commit is returning
E_INVALIDARG there.

[gab, 2012-05-16 19:10:40]

On 2012/05/16 19:04:10, grt wrote:
> i had to back out the vista change.  IPropertyStore::Commit is returning
> E_INVALIDARG there.

:(. We will need to do this extra shortcut stuff on first win-8-boot it looks
like.

[robertshield, 2012-05-17 16:51:08]

lgtm

[commit-bot: I haz the power, 2012-05-17 17:09:08]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/grt@chromium.org/10386167/4004

[commit-bot: I haz the power, 2012-05-17 17:09:35]

Presubmit check for 10386167-4004 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    base

Presubmit checks took 1.7s to calculate.

[grt (UTC plus 2), 2012-05-17 17:55:50]

Brett: adding you for OWNERS approval in base since you reviewed related changes
recently.  Thanks.

[brettw, 2012-05-18 04:53:34]

LGTM but I'm not an expert on this. If you're not completely sure you know what
you're doing, maybe ask Carlos or somebody to comment.

[commit-bot: I haz the power, 2012-05-18 13:56:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/grt@chromium.org/10386167/4004

[commit-bot: I haz the power, 2012-05-18 15:09:06]

Change committed as 137863