Issue 10386158: protobuf: Fix a null/bool conversion.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10386158: protobuf: Fix a null/bool conversion. (Closed)

Created:
8 years, 7 months ago by Nico

Modified:
8 years, 7 months ago

Reviewers:
liujisi

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

protobuf: Fix a null/bool conversion. BUG=none TEST=none TBR=agl Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=137666

Patch Set 1 #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	third_party/protobuf/src/google/protobuf/io/coded_stream.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

Nico

Thanks! On May 16, 2012 10:00 PM, <liujisi@google.com> wrote: > Thanks, patched and submitted in ...

8 years, 7 months ago (2012-05-17 05:42:17 UTC) #4

commit-bot: I haz the power

No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...

8 years, 7 months ago (2012-05-17 05:42:30 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/10386158/1

8 years, 7 months ago (2012-05-17 14:18:22 UTC) #6

commit-bot: I haz the power

8 years, 7 months ago (2012-05-17 14:44:40 UTC) #7

Try job failure for 10386158-1 on win for step "update".
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number...

Step "update" is always a major failure.
Look at the try server FAQ for more details.

Expand Messages | Collapse Messages