Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Unified Diff: runtime/vm/flow_graph_compiler_x64.cc

Issue 10386152: Un revert the revert (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/assembler_x64.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/flow_graph_compiler_x64.cc
===================================================================
--- runtime/vm/flow_graph_compiler_x64.cc (revision 7671)
+++ runtime/vm/flow_graph_compiler_x64.cc (working copy)
@@ -348,7 +348,7 @@
kTypeCheckRuntimeEntry);
// Pop the parameters supplied to the runtime entry. The result of the
// type check runtime call is the checked value.
- __ addq(RSP, Immediate(8 * kWordSize));
+ __ Drop(8);
__ popq(RAX);
__ Bind(&is_assignable);
@@ -479,7 +479,7 @@
ExternalLabel target_label("InlineCache", label_address);
__ call(&target_label);
AddCurrentDescriptor(PcDescriptors::kIcCall, cid, token_index, try_index);
- __ addq(RSP, Immediate(argument_count * kWordSize));
+ __ Drop(argument_count);
}
@@ -497,7 +497,7 @@
try_index,
&StubCode::CallStaticFunctionLabel(),
PcDescriptors::kFuncCall);
- __ addq(RSP, Immediate(argument_count * kWordSize));
+ __ Drop(argument_count);
}
@@ -527,7 +527,7 @@
comp->try_index(),
&StubCode::CallClosureFunctionLabel(),
PcDescriptors::kOther);
- __ addq(RSP, Immediate(argument_count * kWordSize));
+ __ Drop(argument_count);
__ popq(CTX);
}
@@ -836,7 +836,7 @@
GenerateCallRuntime(cid, token_index, try_index, kInstanceofRuntimeEntry);
// Pop the two parameters supplied to the runtime entry. The result of the
// instanceof runtime call will be left as the result of the operation.
- __ addq(RSP, Immediate(7 * kWordSize));
+ __ Drop(7);
Label done;
if (negate_result) {
__ popq(RDX);
@@ -878,9 +878,7 @@
const ExternalLabel label(cls.ToCString(), stub.EntryPoint());
GenerateCall(comp->token_index(), comp->try_index(), &label,
PcDescriptors::kOther);
- for (intptr_t i = 0; i < comp->arguments().length(); i++) {
- __ popq(RCX); // Discard allocation argument
- }
+ __ Drop(comp->arguments().length()); // Discard allocation argument.
}
@@ -900,10 +898,9 @@
comp->token_index(),
comp->try_index(),
kAllocateObjectWithBoundsCheckRuntimeEntry);
- __ popq(RCX); // Pop instantiator type arguments.
- __ popq(RCX); // Pop type arguments.
- __ popq(RCX); // Pop class.
- __ popq(RCX); // Pop source location.
+ // Pop instantiator type arguments, type arguments, class, and
+ // source location.
+ __ Drop(4);
__ popq(RAX); // Pop new instance.
}
« no previous file with comments | « runtime/vm/assembler_x64.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698