Add the necessary plumbing mechanisms to ensure proper WebGL support inside the <browser> tag, whic…

ppapi/proxy/ppb_graphics_3d_proxy.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ppapi/proxy/ppb_graphics_3d_proxy.h"
 
 #include "gpu/command_buffer/client/gles2_implementation.h"
 #include "ppapi/c/pp_errors.h"
 #include "ppapi/proxy/enter_proxy.h"
 #include "ppapi/proxy/plugin_dispatcher.h"
@@ skipping 51 matching lines @@
 }  // namespace
 
 Graphics3D::Graphics3D(const HostResource& resource)
     : PPB_Graphics3D_Shared(resource) {
 }
 
 Graphics3D::~Graphics3D() {
   DestroyGLES2Impl();
 }
 
-bool Graphics3D::Init() {
+bool Graphics3D::Init(gpu::gles2::GLES2Implementation *share_gles2) {

[brettw, 2012/05/25 23:19:41]

Nit: * next to type rather than arg name

   PluginDispatcher* dispatcher = PluginDispatcher::GetForResource(this);
   if (!dispatcher)
     return false;
 
   command_buffer_.reset(
       new PpapiCommandBufferProxy(host_resource(), dispatcher));
   if (!command_buffer_->Initialize())
     return false;
 
-  return CreateGLES2Impl(kCommandBufferSize, kTransferBufferSize);
+  return CreateGLES2Impl(kCommandBufferSize, kTransferBufferSize,
+                         share_gles2);
 }
 
 PP_Bool Graphics3D::InitCommandBuffer() {
   return PP_FALSE;
 }
 
 PP_Bool Graphics3D::SetGetBuffer(int32_t /* transfer_buffer_id */) {
   return PP_FALSE;
 }
 
@@ skipping 46 matching lines @@
     : InterfaceProxy(dispatcher),
       callback_factory_(ALLOW_THIS_IN_INITIALIZER_LIST(this)) {
 }
 
 PPB_Graphics3D_Proxy::~PPB_Graphics3D_Proxy() {
 }
 
 // static
 PP_Resource PPB_Graphics3D_Proxy::CreateProxyResource(
     PP_Instance instance,
-    PP_Resource share_context,
+    PPB_Graphics3D_API* share_context,
     const int32_t* attrib_list) {
   PluginDispatcher* dispatcher = PluginDispatcher::GetForInstance(instance);
+  Graphics3D* share_graphics = static_cast<Graphics3D*>(share_context);
   if (!dispatcher)
     return PP_ERROR_BADARGUMENT;
 
-  // TODO(alokp): Support shared context.
-  DCHECK_EQ(0, share_context);
-  if (share_context != 0)
-    return 0;
+  HostResource share_host;
+  gpu::gles2::GLES2Implementation* share_gles2 = NULL;
+  if (share_context) {
+    share_host = share_graphics->host_resource();
+    share_gles2 = share_graphics->gles2_impl();
+  }
 
   std::vector<int32_t> attribs;
   if (attrib_list) {
     for (const int32_t* attr = attrib_list;
          attr[0] != PP_GRAPHICS3DATTRIB_NONE;
          attr += 2) {
       attribs.push_back(attr[0]);
       attribs.push_back(attr[1]);
     }
   }
   attribs.push_back(PP_GRAPHICS3DATTRIB_NONE);
 
   HostResource result;
   dispatcher->Send(new PpapiHostMsg_PPBGraphics3D_Create(
-      API_ID_PPB_GRAPHICS_3D, instance, attribs, &result));
+      API_ID_PPB_GRAPHICS_3D, instance, share_host, attribs, &result));
   if (result.is_null())
     return 0;
 
   scoped_refptr<Graphics3D> graphics_3d(new Graphics3D(result));
-  if (!graphics_3d->Init())
+  if (!graphics_3d->Init(share_gles2))
     return 0;
   return graphics_3d->GetReference();
 }
 
 bool PPB_Graphics3D_Proxy::OnMessageReceived(const IPC::Message& msg) {
   bool handled = true;
   IPC_BEGIN_MESSAGE_MAP(PPB_Graphics3D_Proxy, msg)
     IPC_MESSAGE_HANDLER(PpapiHostMsg_PPBGraphics3D_Create,
                         OnMsgCreate)
     IPC_MESSAGE_HANDLER(PpapiHostMsg_PPBGraphics3D_InitCommandBuffer,
@@ skipping 18 matching lines @@
     IPC_MESSAGE_HANDLER(PpapiMsg_PPBGraphics3D_SwapBuffersACK,
                         OnMsgSwapBuffersACK)
     IPC_MESSAGE_UNHANDLED(handled = false)
 
   IPC_END_MESSAGE_MAP()
   // FIXME(brettw) handle bad messages!
   return handled;
 }
 
 void PPB_Graphics3D_Proxy::OnMsgCreate(PP_Instance instance,
+                                       HostResource share_context,
                                        const std::vector<int32_t>& attribs,
                                        HostResource* result) {
   if (attribs.empty() || attribs.back() != PP_GRAPHICS3DATTRIB_NONE)
     return;  // Bad message.
 
   thunk::EnterResourceCreation enter(instance);
+  PPB_Graphics3D_API *share_api = NULL;
+  if (share_context.host_resource() != 0) {
+    thunk::EnterResource<thunk::PPB_Graphics3D_API>
+        enter_share(share_context.host_resource(), true);
+    if (!enter_share.succeeded())
+      return;
+    share_api = enter_share.object();
+  }
+
   if (enter.succeeded()) {
     result->SetHostResource(
-        instance,
-        enter.functions()->CreateGraphics3DRaw(instance, 0, &attribs.front()));
+      instance,
+      enter.functions()->CreateGraphics3DRaw(instance,
+                                             share_api,
+                                             &attribs.front()));
   }
 }
 
 void PPB_Graphics3D_Proxy::OnMsgInitCommandBuffer(
     const HostResource& context) {
   EnterHostFromHostResource<PPB_Graphics3D_API> enter(context);
   if (enter.failed())
     return;
 
   if (!enter.object()->InitCommandBuffer())
@@ skipping 99 matching lines @@
 void PPB_Graphics3D_Proxy::SendSwapBuffersACKToPlugin(
     int32_t result,
     const HostResource& context) {
   dispatcher()->Send(new PpapiMsg_PPBGraphics3D_SwapBuffersACK(
       API_ID_PPB_GRAPHICS_3D, context, result));
 }
 
 }  // namespace proxy
 }  // namespace ppapi