Add the necessary plumbing mechanisms to ensure proper WebGL support inside the <browser> tag, whic…

content/renderer/browser_plugin/guest_to_embedder_channel.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/browser_plugin/guest_to_embedder_channel.h"
 
 #include "base/process_util.h"
 #include "content/common/browser_plugin_messages.h"
 #include "content/common/child_process.h"
 #include "content/renderer/browser_plugin/browser_plugin_channel_manager.h"
@@ skipping 146 matching lines @@
     RenderViewImpl* render_view) {
   std::vector<int32_t> attribs;
   attribs.push_back(PP_GRAPHICS3DATTRIB_NONE);
 
   ppapi::HostResource resource;
   DCHECK(render_view->guest_pp_instance());
   // TODO(fsamuel): Support child contexts.
   bool success = Send(new PpapiHostMsg_PPBGraphics3D_Create(
       ppapi::API_ID_PPB_GRAPHICS_3D,
       render_view->guest_pp_instance(),
+      offscreen ? render_view->guest_graphics_resource()
+                : ppapi::HostResource(),

[piman, 2012/05/24 23:10:08]

No, you should pass here the WebGraphicsContext3DCommandBufferImpl you're
sharing with, and unwrap it to get to the resource.
you can have several onscreen contexts (say for different renderviews) that need
to share together. Also onscreen vs shared context can be created in any order,
but they need to share with one another.

[(scshunt), 2012/05/24 23:18:07]

I'm going to be changing this up a lot here now that I have a better idea of the
sharing model I think we want to use, so anything here will be temporary anyway.

If I change this into a ppapi::HostResource() in the meanwhile (getting rid of
the conditional), and drop the rest of the file, is this good to go? It would be
good to upstream the rest of this code.

       attribs,
       &resource));
   if (!success || resource.is_null())
     return false;
   if (!offscreen) {
     PP_Bool result = PP_FALSE;
     Send(new PpapiHostMsg_PPBInstance_BindGraphics(
             ppapi::API_ID_PPB_INSTANCE,
             render_view->guest_pp_instance(),
             resource,
             &result));
     if (result != PP_TRUE)
       return false;
+    render_view->set_guest_graphics_resource(resource);

[piman, 2012/05/24 23:10:08]

err, what if we have more than 1 "onscreen" context per render view? This
happens today during lost context recovery (you may have at the same time the
old context which is lost, and the new one).

[(scshunt), 2012/05/24 23:18:07]

This is actually an unrelated fix, and is an improvement over the old code, but
only slightly. This will probably change now that I think I have a good model of
the sharing model.

[Fady Samuel, 2012/05/24 23:19:00]

PpapiCommandBufferProxy knows about its HostResource. So the old, lost context
will still be able to talk to the embedder.

guest_graphics_resource is only used in RenderViewImpl::DidInitiatePaint to
inform the embedder it should invalidate its browser plugin container.

   }
 
   CommandBufferProxy* command_buffer =
       new ppapi::proxy::PpapiCommandBufferProxy(resource, this);
   command_buffer->Initialize();
   context->InitializeWithCommandBuffer(
       command_buffer,
       attributes,
       false /* bind generates resources */);
-  render_view->set_guest_graphics_resource(resource);
   return true;
 }
 
 void GuestToEmbedderChannel::AddGuest(
     PP_Instance instance,
     RenderViewImpl* render_view) {
   DCHECK(instance);
   DCHECK(render_view_instances_.find(instance) == render_view_instances_.end());
   render_view_instances_[instance] = render_view->AsWeakPtr();
 }
@@ skipping 71 matching lines @@
       render_view->GetWebView()->handleInputEvent(*web_input_event));
 }
 
 void GuestToEmbedderChannel::OnContextLost(PP_Instance instance) {
   DCHECK(render_view_instances_.find(instance) != render_view_instances_.end());
   RenderViewImpl* render_view = render_view_instances_[instance];
   render_view->GetWebView()->loseCompositorContext(1);
 }
 
 }  // namespace content