Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Unified Diff: chrome/browser/automation/automation_event_queue.cc

Issue 10386144: Fixed a possible memory leak and support null pointers in AutomationEventObservers' NotifyEvent. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/automation/automation_event_queue.cc
diff --git a/chrome/browser/automation/automation_event_queue.cc b/chrome/browser/automation/automation_event_queue.cc
index 469887eace9be8f3cc47908fa375f77898a4eee4..411a969507730e977da01f711c1530d8cddd2ea8 100644
--- a/chrome/browser/automation/automation_event_queue.cc
+++ b/chrome/browser/automation/automation_event_queue.cc
@@ -4,6 +4,7 @@
#include <algorithm>
+#include "base/logging.h"
#include "chrome/browser/automation/automation_event_observers.h"
#include "chrome/browser/automation/automation_event_queue.h"
#include "chrome/browser/automation/automation_provider_json.h"
@@ -74,6 +75,8 @@ AutomationEventQueue::AutomationEvent* AutomationEventQueue::PopEvent(
void AutomationEventQueue::NotifyEvent(
AutomationEventQueue::AutomationEvent* event) {
+ DCHECK(event);
+ VLOG(2) << "AutomationEventQueue::NotifyEvent id=" << event->GetId();
event_queue_.push_front(event);
CheckReturnEvent();
}
@@ -87,6 +90,7 @@ int AutomationEventQueue::AddObserver(AutomationEventObserver* observer) {
bool AutomationEventQueue::RemoveObserver(int observer_id) {
if (observers_.find(observer_id) != observers_.end()) {
+ VLOG(2) << "AutomationEventQueue::RemoveObserver id=" << observer_id;
delete observers_[observer_id];
observers_.erase(observer_id);
return true;

Powered by Google App Engine
This is Rietveld 408576698