Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 10386141: Fix EtwTraceConsumerRealtimeTest. (Closed)

Created:
8 years, 7 months ago by Sigurður Ásgeirsson
Modified:
8 years, 7 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews, erikwright (departed), brettw-cc_chromium.org
Visibility:
Public.

Description

Fix EtwTraceConsumerRealtimeTest. The EtwTraceConsumerRealtimeTest test fixture subclass contained a second instance of the test_provider_ member variable. This occluded the initialized superclass instance's variable and led to the test relying on uninitialized data. BUG=127671 TEST=Unittests pass on Vista. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=137129

Patch Set 1 #

Patch Set 2 : Enable the test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M base/win/event_trace_consumer_unittest.cc View 1 2 chunks +1 line, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Sigurður Ásgeirsson
This should fix it for realz. Funny that we'd only hit this on the Vista ...
8 years, 7 months ago (2012-05-15 13:30:06 UTC) #1
Mark Mentovai
Whoa, oops. LGTM
8 years, 7 months ago (2012-05-15 13:32:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/siggi@chromium.org/10386141/3001
8 years, 7 months ago (2012-05-15 13:32:52 UTC) #3
commit-bot: I haz the power
8 years, 7 months ago (2012-05-15 15:03:57 UTC) #4
Change committed as 137129

Powered by Google App Engine
This is Rietveld 408576698