Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Unified Diff: runtime/bin/process.dart

Issue 10386140: Update documentation on Process.close to explain issues with closing before reading out all content… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/process.dart
===================================================================
--- runtime/bin/process.dart (revision 7584)
+++ runtime/bin/process.dart (working copy)
@@ -98,11 +98,13 @@
abstract void kill();
/**
- * Terminates the streams of a process. [close] most be called on a
- * process to free the system resources associated with it. Usually,
- * close should be called in [onExit]. Once a process has been
- * closed it can no longer be killed and [onExit] is detached so the
- * application is not notified of process termination.
+ * Terminates the streams of a process. [close] must be called on a
+ * process to free the system resources associated with it if not all
+ * data on the stdout and stderr streams have been read. Usually,
+ * close should be called in [onExit], but care must be taken to actually
+ * wait on the stderr and stdout streams to close if all data is required.
+ * Once a process has been closed it can no longer be killed and [onExit]
+ * is detached so the application is not notified of process termination.
*/
abstract void close();
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698