Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 10386130: Coverity: Fix pass by value error in SpeechRecognitionHypothesis constructor. (Closed)

Created:
8 years, 7 months ago by kmadhusu
Modified:
8 years, 7 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, Satish, jam, jochen+watch-content_chromium.org
Visibility:
Public.

Description

Coverity: Fix pass by value error in SpeechRecognitionHypothesis constructor. CID=103455 BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=137171

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/public/common/speech_recognition_result.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
kmadhusu
8 years, 7 months ago (2012-05-15 01:19:11 UTC) #1
Primiano Tucci (use gerrit)
On 2012/05/15 01:19:11, kmadhusu wrote: LGTM, but I guess you'll need one from an OWNER.
8 years, 7 months ago (2012-05-15 08:46:48 UTC) #2
Satish
lgtm
8 years, 7 months ago (2012-05-15 09:39:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kmadhusu@chromium.org/10386130/1
8 years, 7 months ago (2012-05-15 15:27:37 UTC) #4
commit-bot: I haz the power
Presubmit check for 10386130-1 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 7 months ago (2012-05-15 15:27:43 UTC) #5
kmadhusu
joi@: content/public OWNERs check failed. Can you LGTM this change? Thanks.
8 years, 7 months ago (2012-05-15 15:45:48 UTC) #6
Jói
LGTM
8 years, 7 months ago (2012-05-15 16:37:03 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kmadhusu@chromium.org/10386130/1
8 years, 7 months ago (2012-05-15 16:38:00 UTC) #8
commit-bot: I haz the power
8 years, 7 months ago (2012-05-15 18:00:21 UTC) #9
Change committed as 137171

Powered by Google App Engine
This is Rietveld 408576698