Issue 10386118: ui: Do not expose the underline type (vector) used in ListModel.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10386118: ui: Do not expose the underline type (vector) used in ListModel. (Closed)

Created:
8 years, 7 months ago by tfarina

Modified:
8 years, 7 months ago

Reviewers:
xiyuan

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

ui: Do not expose the underline type (vector) used in ListModel. And while I'm here rename item_at to GetItemAt. I think this is more consistent with AddAt, DeleteAt, etc. TEST=ui_unittests --gtest_filter=ListModel* R=xiyuan@chromium.org TBR=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=137112

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+12 lines, -15 lines)			Patch
M	ui/app_list/app_list_model.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	ui/base/models/list_model.h	View	4 chunks	+5 lines, -8 lines	0 comments	Download
M	ui/base/models/list_model_unittest.cc	View	3 chunks	+6 lines, -6 lines	0 comments	Download

Total messages: 2 (0 generated)

lgtm