Chromium Code Reviews Chromium Code Reviews
Issue 10386108:
Change the way _EXPORT macros look. (Closed)
Base URL: svn://svn.chromium.org/chrome/trunk/src| OLD | NEW |
|---|---|
| 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. | 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. |
| 2 // Use of this source code is governed by a BSD-style license that can be | 2 // Use of this source code is governed by a BSD-style license that can be |
| 3 // found in the LICENSE file. | 3 // found in the LICENSE file. |
| 4 | 4 |
| 5 #ifndef UI_AURA_AURA_EXPORT_H | 5 #ifndef UI_AURA_AURA_EXPORT_H |
| 6 #define UI_AURA_AURA_EXPORT_H | 6 #define UI_AURA_AURA_EXPORT_H |
| 7 #pragma once | 7 #pragma once |
| 8 | 8 |
| 9 // Defines AURA_EXPORT so that functionality implemented by the aura module | 9 // Defines AURA_EXPORT so that functionality implemented by the aura module |
| 10 // can be exported to consumers. | 10 // can be exported to consumers. |
| 11 | 11 |
| 12 #if defined(COMPONENT_BUILD) | 12 #if defined(COMPONENT_BUILD) |
| 13 #if defined(WIN32) | 13 #if defined(WIN32) |
| 14 | 14 |
| 15 #if defined(AURA_IMPLEMENTATION) | 15 #if defined(AURA_IMPLEMENTATION) |
| 16 #define AURA_EXPORT __declspec(dllexport) | 16 #define AURA_EXPORT __declspec(dllexport) |
| 17 #else | 17 #else |
| 18 #define AURA_EXPORT __declspec(dllimport) | 18 #define AURA_EXPORT __declspec(dllimport) |
| 19 #endif // defined(AURA_IMPLEMENTATION) | 19 #endif // defined(AURA_IMPLEMENTATION) |
| 20 | 20 |
| 21 #else // defined(WIN32) | 21 #else // defined(WIN32) |
| 22 #if defined(AURA_IMPLEMENTATION) | |
|
tfarina
2012/05/15 18:07:24
nit: should we do the same to ui/app_list/app_list
Nico
2012/05/15 18:15:43
Yes. I tried to add it to all _export.h files. May
| |
| 22 #define AURA_EXPORT __attribute__((visibility("default"))) | 23 #define AURA_EXPORT __attribute__((visibility("default"))) |
| 24 #else | |
| 25 #define AURA_EXPORT | |
| 26 #endif | |
| 23 #endif | 27 #endif |
| 24 | 28 |
| 25 #else // defined(COMPONENT_BUILD) | 29 #else // defined(COMPONENT_BUILD) |
| 26 #define AURA_EXPORT | 30 #define AURA_EXPORT |
| 27 #endif | 31 #endif |
| 28 | 32 |
| 29 #endif // UI_AURA_AURA_EXPORT_H | 33 #endif // UI_AURA_AURA_EXPORT_H |
| OLD | NEW |
