Issue 10386106: Fixed crashes when data is NULL.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10386106: Fixed crashes when data is NULL. (Closed)

Created:
8 years, 7 months ago by Vitaly Buka (NO REVIEWS)

Modified:
8 years, 7 months ago

Reviewers:
Albert Bodenhamer

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Sometimes data is NULL. I am not sure if it's correct behavior , but it's safe just to check pointer. BUG=127865 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=136935

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -6 lines)			Patch
	M	chrome/browser/ui/webui/print_preview/print_preview_handler.h	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	chrome/browser/ui/webui/print_preview/print_preview_handler.cc	View		2 chunks	+7 lines, -5 lines	0 comments	Download

Total messages: 4 (0 generated)

Albert Bodenhamer

LGTM |data| should never be NULL. I'd still like to understand why we started seeing ...

8 years, 7 months ago (2012-05-14 16:17:58 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/10386106/6001

8 years, 7 months ago (2012-05-14 17:13:32 UTC) #3

Change committed as 136935