Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 10386087: Replace rip lea with eip (Closed)

Created:
8 years, 7 months ago by khim
Modified:
8 years, 7 months ago
Reviewers:
eaeltsin
CC:
native-client-reviews_googlegroups.com
Base URL:
http://git.chromium.org/native_client/nacl-gcc.git@master
Visibility:
Public.

Description

Replace rip lea with eip Fix for the POINTERS_EXTEND_UNSIGNED > 0 problem of keeping high part of rip. Note that ix86_lea_decompose_address does not produce pc_rtx in base or index even if -fPIC is used: pc_rtx is added later in print_operand_address_parts. That's why we are handling !base and !index case here. BUG=http://code.google.com/p/nativeclient/issues/detail?id=1304 TEST=see reproducer in bug above R=eaeltsin@google.com Committed: https://git.chromium.org/gitweb?p=native_client/nacl-gcc.git;a=commit;h=61ff43b

Patch Set 1 #

Patch Set 2 : Handle all cases handled by print_operand_address_parts #

Total comments: 1

Patch Set 3 : Create and use helper function #

Patch Set 4 : Git-fu error #

Patch Set 5 : Typo #

Patch Set 6 : space #

Patch Set 7 : remove [gcc] prefix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -14 lines) Patch
M gcc/config/i386/i386.c View 1 chunk +36 lines, -0 lines 0 comments Download
M gcc/config/i386/i386.md View 1 2 2 chunks +4 lines, -14 lines 0 comments Download
M gcc/config/i386/i386-protos.h View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
khim
8 years, 7 months ago (2012-05-11 08:13:37 UTC) #1
eaeltsin
Please verify that specs pass.
8 years, 7 months ago (2012-05-11 08:37:09 UTC) #2
pasko-google - do not use
wow! great! that was fast! I hope the SDK update were so fast..
8 years, 7 months ago (2012-05-11 09:04:49 UTC) #3
pasko-google - do not use
On 2012/05/11 09:04:49, pasko wrote: > wow! great! that was fast! > > I hope ...
8 years, 7 months ago (2012-05-11 09:05:10 UTC) #4
eaeltsin
https://chromiumcodereview.appspot.com/10386087/diff/5001/gcc/config/i386/i386.md File gcc/config/i386/i386.md (right): https://chromiumcodereview.appspot.com/10386087/diff/5001/gcc/config/i386/i386.md#newcode2418 gcc/config/i386/i386.md:2418: if (TARGET_NACL) As this check is used twice, can ...
8 years, 7 months ago (2012-05-11 12:33:31 UTC) #5
pasko-google - do not use
small nit: the prefix "[gcc]" is now redundant
8 years, 7 months ago (2012-05-11 12:39:38 UTC) #6
eaeltsin
8 years, 7 months ago (2012-05-11 12:54:10 UTC) #7
lgtm if bots pass

Powered by Google App Engine
This is Rietveld 408576698