RFC: Start refactoring to provide more than a single backend.

lib/compiler/implementation/emitter.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /**
  * A function element that represents a closure call. The signature is copied
  * from the given element.
  */
 class ClosureInvocationElement extends FunctionElement {
   ClosureInvocationElement(SourceString name,
                            FunctionElement other)
       : super.from(name, other, other.enclosingElement);
 
   isInstanceMember() => true;
 }
 
 /**
  * Generates the code for all used classes in the program. Static fields (even
  * in classes) are ignored, since they can be treated as non-class elements.
  *
  * The code for the containing (used) methods must exist in the [:universe:].
  */
 class CodeEmitterTask extends CompilerTask {
   bool needsInheritFunction = false;
   bool needsDefineClass = false;
   bool needsClosureClass = false;
   final Namer namer;
-  final NativeEmitter nativeEmitter;
+  NativeEmitter nativeEmitter;
   StringBuffer boundClosureBuffer;
   StringBuffer mainBuffer;
   /** Shorter access to [isolatePropertiesName]. Both here in the code, as
       well as in the generated code. */
   String isolateProperties;
 
   CodeEmitterTask(Compiler compiler)
       : namer = compiler.namer,
-        nativeEmitter = new NativeEmitter(compiler),
         boundClosureBuffer = new StringBuffer(),
         mainBuffer = new StringBuffer(),
-        super(compiler);
+        super(compiler) {
+    nativeEmitter = new NativeEmitter(this);
+  }
 
   String get name() => 'CodeEmitter';
 
   String get defineClassName()
       => '${namer.ISOLATE}.\$defineClass';
   String get finishClassesName()
       => '${namer.ISOLATE}.\$finishClasses';
   String get finishIsolateConstructorName()
       => '${namer.ISOLATE}.\$finishIsolateConstructor';
   String get pendingClassesName()
@@ skipping 719 matching lines @@
 };
 ''');
   }
 
   void emitExtraAccessors(Element member,
                           void defineInstanceMember(String invocationName,
                                                     String definition)) {
     if (member.kind == ElementKind.GETTER || member.kind == ElementKind.FIELD) {
       Set<Selector> selectors = compiler.universe.invokedNames[member.name];
       if (selectors !== null && !selectors.isEmpty()) {
-        compiler.emitter.emitCallStubForGetter(member, selectors,
-                                               defineInstanceMember);
+        emitCallStubForGetter(member, selectors, defineInstanceMember);

[Anton Muhin, 2012/05/14 14:36:45]

might have been an oversight while moving code around, but still, is it ok?

[floitsch, 2012/05/14 15:10:29]

LGTM.

       }
     } else if (member.kind == ElementKind.FUNCTION) {
       if (compiler.universe.hasGetter(member, compiler)) {
-        compiler.emitter.emitDynamicFunctionGetter(member,
-                                                   defineInstanceMember);
+        emitDynamicFunctionGetter(member, defineInstanceMember);
       }
     }
   }
 
   void emitNoSuchMethodCalls(void defineInstanceMember(String invocationName,
                                                        String definition)) {
     // Do not generate no such method calls if there is no class.
     if (compiler.universe.instantiatedClasses.isEmpty()) return;
 
     ClassElement objectClass =
@@ skipping 183 matching lines @@
       mainBuffer.add('function init() {\n');
       mainBuffer.add('  $isolateProperties = {};\n');
       addDefineClassAndFinishClassFunctionsIfNecessary(mainBuffer);
       emitFinishIsolateConstructor(mainBuffer);
       mainBuffer.add('}\n');
       compiler.assembledCode = mainBuffer.toString();
     });
     return compiler.assembledCode;
   }
 }