Rename nacl::RefCounted to nacl::RefCountedThreadSafe

Rename nacl::RefCounted to nacl::RefCountedThreadSafe, to make it easier to alias as gpu::RefCountedThreadSafe.

Additionally, ensure all of the nacl::RefCountedThreadSafe-derived classes
do not have public destructors.

BUG=123295
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=137936

[Ryan Sleevi, 2012-05-11 01:17:05]

Hey Mark,

Thanks for pointing out the include_dir hackery. Please take a look.

Since the ppruntime_lib doesn't go through the Clang plugin, I had missed some
RefCounted types having public destructors. That's also fixed here, in part to
make sure everything was working as expected and I was compiling correctly.

[Ryan Sleevi, 2012-05-11 01:30:37]

http://codereview.chromium.org/10386080/diff/1/ppapi/native_client/src/includ...
File ppapi/native_client/src/include/ref_counted.h (right):

http://codereview.chromium.org/10386080/diff/1/ppapi/native_client/src/includ...
ppapi/native_client/src/include/ref_counted.h:3: // found in the LICENSE file.
I wasn't sure whether or not it was appropriate to update this header, like
Brett did back in http://crrev.com/100755

I suspect the presubmit hooks won't like this saying "Native Client" here,
rather than "Chromium"

Thoughts?

[Ryan Sleevi, 2012-05-11 18:14:00]

Actually, disregard this. It worked locally because I had also deleted the file
from the DEPS'd native_client repo.

Looks like I'll need to do multi-pronged landing
1) Copy the file from native_client (NaCL repo) -> ppapi/native_client (Chromium
repo)
2) Remove the file from native_client (NaCL repo)
3) Roll DEPS (Chromium repo)
4) Make changes (Chromium repo)

Will send CLs for 1 & 2. This is effectively CL 4, so will leave open and adjust
accordingly.

[Ryan Sleevi, 2012-05-17 17:46:52]

PTAL. Updated now that

1) File copied to Chromium
2) DEPS updated in NaCL
3) File removed in NaCL
4) DEPS updated in Chromium

have been done

[Ryan Sleevi, 2012-05-18 17:13:09]

mark: Ping?

[Mark Seaborn, 2012-05-18 18:26:22]

LGTM

http://codereview.chromium.org/10386080/diff/5001/gpu/command_buffer/client/r...
File gpu/command_buffer/client/ref_counted.h (right):

http://codereview.chromium.org/10386080/diff/5001/gpu/command_buffer/client/r...
gpu/command_buffer/client/ref_counted.h:9: #include
"native_client/src/include/ref_counted.h"
Should there be a TODO here to remove this and just use base's ref_counted.h?

[Ryan Sleevi, 2012-05-18 18:30:18]

http://codereview.chromium.org/10386080/diff/5001/gpu/command_buffer/client/r...
File gpu/command_buffer/client/ref_counted.h (right):

http://codereview.chromium.org/10386080/diff/5001/gpu/command_buffer/client/r...
gpu/command_buffer/client/ref_counted.h:9: #include
"native_client/src/include/ref_counted.h"
On 2012/05/18 18:26:23, Mark Seaborn wrote:
> Should there be a TODO here to remove this and just use base's ref_counted.h?

I'm not familiar enough with this code to know/say, but I'll happily add a
TODO(mseaborn) if you think it should be.

Given that this is compiled under the nacl toolchain, I would imagine that base/
(inc. base/ref_counted.h) would be problematic for nacl-glibc. Currently
ref_counted.h is implemented in terms of atomics, which themselves are
implemented in terms of asm snippets, and I understood that to be frowned upon
for NaCL.

[commit-bot: I haz the power, 2012-05-18 18:31:03]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rsleevi@chromium.org/10386080/5001

[commit-bot: I haz the power, 2012-05-18 18:31:15]

Presubmit check for 10386080-5001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Warnings **
License must match:
.*? Copyright \(c\) 2012 The Chromium Authors\. All rights reserved\.\n.*? Use
of this source code is governed by a BSD-style license that can be\n.*? found in
the LICENSE file\.(?: \*/)?\n
Found a bad license header in these files:
  ppapi/native_client/src/shared/ppapi_proxy/plugin_ppb_buffer.h \
  ppapi/native_client/src/shared/ppapi_proxy/plugin_ppb_image_data.h \
  ppapi/native_client/src/shared/ppapi_proxy/plugin_ppb_view.h

Presubmit checks took 2.2s to calculate.

[commit-bot: I haz the power, 2012-05-18 18:48:37]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rsleevi@chromium.org/10386080/10003

[commit-bot: I haz the power, 2012-05-18 20:09:56]

Change committed as 137936