Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1261)

Issue 10386076: convert help page to loadTimeData (Closed)

Created:
8 years, 7 months ago by Evan Stade
Modified:
8 years, 7 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, arv (Not doing code reviews)
Visibility:
Public.

Description

convert help page to loadTimeData BUG=122753 TEST=manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=137554

Patch Set 1 #

Patch Set 2 : add test as well #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -16 lines) Patch
M chrome/browser/resources/help/help.html View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/resources/help/help.js View 4 chunks +12 lines, -13 lines 0 comments Download
A chrome/browser/ui/webui/help/help_browsertest.js View 1 1 chunk +21 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/help/help_ui.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 1 chunk +1 line, -0 lines 1 comment Download

Messages

Total messages: 8 (0 generated)
Evan Stade
8 years, 7 months ago (2012-05-10 22:27:52 UTC) #1
Dan Beam
lgtm w/snark http://codereview.chromium.org/10386076/diff/2001/chrome/chrome_tests.gypi File chrome/chrome_tests.gypi (right): http://codereview.chromium.org/10386076/diff/2001/chrome/chrome_tests.gypi#newcode2904 chrome/chrome_tests.gypi:2904: 'browser/ui/webui/help/help_browsertest.js', I have no clue how the ...
8 years, 7 months ago (2012-05-10 22:36:19 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/10386076/2001
8 years, 7 months ago (2012-05-14 22:45:22 UTC) #3
commit-bot: I haz the power
Try job failure for 10386076-2001 (retry) on linux_chromeos for step "compile" (clobber build). It's a ...
8 years, 7 months ago (2012-05-14 23:02:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/10386076/2001
8 years, 7 months ago (2012-05-15 03:05:42 UTC) #5
commit-bot: I haz the power
The commit queue went berserk retrying too often for a seemingly flaky test. Builder is ...
8 years, 7 months ago (2012-05-15 04:43:03 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/10386076/2001
8 years, 7 months ago (2012-05-16 21:44:02 UTC) #7
commit-bot: I haz the power
8 years, 7 months ago (2012-05-16 23:24:44 UTC) #8
Change committed as 137554

Powered by Google App Engine
This is Rietveld 408576698