Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1030)

Unified Diff: vm/dart_api_impl.cc

Issue 10386073: Revert change 7506 to check on build failure. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « include/dart_api.h ('k') | vm/dart_api_impl_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: vm/dart_api_impl.cc
===================================================================
--- vm/dart_api_impl.cc (revision 7506)
+++ vm/dart_api_impl.cc (working copy)
@@ -2994,15 +2994,6 @@
// --- Scripts and Libraries ---
-DART_EXPORT Dart_Handle Dart_SetLibraryTagHandler(
- Dart_LibraryTagHandler handler) {
- Isolate* isolate = Isolate::Current();
- CHECK_ISOLATE(isolate);
- isolate->set_library_tag_handler(handler);
- return Api::Success(isolate);
-}
-
-
// NOTE: Need to pass 'result' as a parameter here in order to avoid
// warning: variable 'result' might be clobbered by 'longjmp' or 'vfork'
// which shows up because of the use of setjmp.
@@ -3037,6 +3028,7 @@
DART_EXPORT Dart_Handle Dart_LoadScript(Dart_Handle url,
Dart_Handle source,
+ Dart_LibraryTagHandler handler,
Dart_Handle import_map) {
TIMERSCOPE(time_script_loading);
Isolate* isolate = Isolate::Current();
@@ -3057,6 +3049,7 @@
return Api::NewError("%s: A script has already been loaded from '%s'.",
CURRENT_FUNC, library_url.ToCString());
}
+ isolate->set_library_tag_handler(handler);
library = Library::New(url_str);
if (mapping_array.IsNull()) {
library.set_import_map(Array::Handle(isolate, Array::Empty()));
« no previous file with comments | « include/dart_api.h ('k') | vm/dart_api_impl_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698