Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Unified Diff: bin/main.cc

Issue 10386073: Revert change 7506 to check on build failure. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « bin/gen_snapshot.cc ('k') | include/dart_api.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: bin/main.cc
===================================================================
--- bin/main.cc (revision 7506)
+++ bin/main.cc (working copy)
@@ -429,7 +429,7 @@
}
free(name);
}
- return Dart_LoadScript(script_url, source, import_map);
+ return Dart_LoadScript(script_url, source, LibraryTagHandler, import_map);
}
@@ -450,13 +450,6 @@
Builtin::SetNativeResolver(Builtin::kIOLibrary);
}
- // Set up the library tag handler for this isolate.
- Dart_Handle result = Dart_SetLibraryTagHandler(LibraryTagHandler);
- if (Dart_IsError(result)) {
- *error = strdup(Dart_GetError(result));
- return false;
- }
-
// Prepare builtin and its dependent libraries for use to resolve URIs.
Dart_Handle uri_lib = Builtin::LoadLibrary(Builtin::kUriLibrary);
if (Dart_IsError(uri_lib)) {
@@ -468,6 +461,11 @@
*error = strdup(Dart_GetError(builtin_lib));
return false;
}
+ Dart_Handle library = Dart_LibraryImportLibrary(builtin_lib, uri_lib);
+ if (Dart_IsError(library)) {
+ *error = strdup(Dart_GetError(library));
+ return false;
+ }
if (package_root != NULL) {
Dart_Handle dart_args[1];
@@ -488,7 +486,7 @@
}
// Load the specified application script into the newly created isolate.
- Dart_Handle library = LoadScript(builtin_lib, import_map_options);
+ library = LoadScript(builtin_lib, import_map_options);
if (Dart_IsError(library)) {
*error = strdup(Dart_GetError(library));
Dart_ExitScope();
« no previous file with comments | « bin/gen_snapshot.cc ('k') | include/dart_api.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698