Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Side by Side Diff: src/mark-compact-inl.h

Issue 10386046: Implement map collection for incremental marking. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Minor fix in live bytes counting. Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/mark-compact.cc ('k') | test/cctest/test-heap.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
11 // with the distribution. 11 // with the distribution.
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
45 45
46 46
47 void MarkCompactCollector::SetFlags(int flags) { 47 void MarkCompactCollector::SetFlags(int flags) {
48 sweep_precisely_ = ((flags & Heap::kSweepPreciselyMask) != 0); 48 sweep_precisely_ = ((flags & Heap::kSweepPreciselyMask) != 0);
49 reduce_memory_footprint_ = ((flags & Heap::kReduceMemoryFootprintMask) != 0); 49 reduce_memory_footprint_ = ((flags & Heap::kReduceMemoryFootprintMask) != 0);
50 abort_incremental_marking_ = 50 abort_incremental_marking_ =
51 ((flags & Heap::kAbortIncrementalMarkingMask) != 0); 51 ((flags & Heap::kAbortIncrementalMarkingMask) != 0);
52 } 52 }
53 53
54 54
55 bool MarkCompactCollector::MarkObjectAndPush(HeapObject* obj) {
56 if (MarkObjectWithoutPush(obj)) {
57 marking_deque_.PushBlack(obj);
58 return true;
59 }
60 return false;
61 }
62
63
55 void MarkCompactCollector::MarkObject(HeapObject* obj, MarkBit mark_bit) { 64 void MarkCompactCollector::MarkObject(HeapObject* obj, MarkBit mark_bit) {
56 ASSERT(Marking::MarkBitFrom(obj) == mark_bit); 65 ASSERT(Marking::MarkBitFrom(obj) == mark_bit);
57 if (!mark_bit.Get()) { 66 if (!mark_bit.Get()) {
58 mark_bit.Set(); 67 mark_bit.Set();
59 MemoryChunk::IncrementLiveBytesFromGC(obj->address(), obj->Size()); 68 MemoryChunk::IncrementLiveBytesFromGC(obj->address(), obj->Size());
60 ProcessNewlyMarkedObject(obj); 69 ProcessNewlyMarkedObject(obj);
61 } 70 }
62 } 71 }
63 72
64 73
65 bool MarkCompactCollector::MarkObjectWithoutPush(HeapObject* object) { 74 bool MarkCompactCollector::MarkObjectWithoutPush(HeapObject* obj) {
66 MarkBit mark = Marking::MarkBitFrom(object); 75 MarkBit mark_bit = Marking::MarkBitFrom(obj);
67 bool old_mark = mark.Get(); 76 if (!mark_bit.Get()) {
68 if (!old_mark) SetMark(object, mark); 77 SetMark(obj, mark_bit);
69 return old_mark; 78 return true;
79 }
80 return false;
70 } 81 }
71 82
72 83
73 void MarkCompactCollector::MarkObjectAndPush(HeapObject* object) {
74 if (!MarkObjectWithoutPush(object)) marking_deque_.PushBlack(object);
75 }
76
77
78 void MarkCompactCollector::SetMark(HeapObject* obj, MarkBit mark_bit) { 84 void MarkCompactCollector::SetMark(HeapObject* obj, MarkBit mark_bit) {
79 ASSERT(!mark_bit.Get()); 85 ASSERT(!mark_bit.Get());
80 ASSERT(Marking::MarkBitFrom(obj) == mark_bit); 86 ASSERT(Marking::MarkBitFrom(obj) == mark_bit);
81 mark_bit.Set(); 87 mark_bit.Set();
82 MemoryChunk::IncrementLiveBytesFromGC(obj->address(), obj->Size()); 88 MemoryChunk::IncrementLiveBytesFromGC(obj->address(), obj->Size());
83 if (obj->IsMap()) { 89 if (obj->IsMap()) {
84 heap_->ClearCacheOnMap(Map::cast(obj)); 90 heap_->ClearCacheOnMap(Map::cast(obj));
85 } 91 }
86 } 92 }
87 93
(...skipping 17 matching lines...) Expand all
105 SlotsBuffer::FAIL_ON_OVERFLOW)) { 111 SlotsBuffer::FAIL_ON_OVERFLOW)) {
106 EvictEvacuationCandidate(object_page); 112 EvictEvacuationCandidate(object_page);
107 } 113 }
108 } 114 }
109 } 115 }
110 116
111 117
112 } } // namespace v8::internal 118 } } // namespace v8::internal
113 119
114 #endif // V8_MARK_COMPACT_INL_H_ 120 #endif // V8_MARK_COMPACT_INL_H_
OLDNEW
« no previous file with comments | « src/mark-compact.cc ('k') | test/cctest/test-heap.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698