Issue 10386045: Properly set ElementsKind of empty FAST_DOUBLE_ELEMENTS arrays when transitioning.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10386045: Properly set ElementsKind of empty FAST_DOUBLE_ELEMENTS arrays when transitioning. (Closed)

Created:
8 years, 7 months ago by danno

Modified:
8 years, 7 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Properly set ElementsKind of empty FAST_DOUBLE_ELEMENTS arrays when transitioning. R=jkummerow@chromium.org BUG=chromium:117409 TEST=test/mjsunit/regress/regress-117409.js Committed: https://code.google.com/p/v8/source/detail?r=11533

Patch Set 1 #

Total comments: 2

Patch Set 2 : Review feedback #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+75 lines, -13 lines)			Patch
M	src/builtins.cc	View		1 chunk	+9 lines, -2 lines	0 comments	Download
M	src/objects.cc	View		2 chunks	+5 lines, -4 lines	0 comments	Download
M	src/objects-printer.cc	View		1 chunk	+9 lines, -7 lines	0 comments	Download
A	test/mjsunit/regress/regress-117409.js	View	1	1 chunk	+52 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

8 years, 7 months ago (2012-05-09 15:02:58 UTC) #2

LGTM with nits.

https://chromiumcodereview.appspot.com/10386045/diff/1/test/mjsunit/regress/r...
File test/mjsunit/regress/regress-117409.js (right):

https://chromiumcodereview.appspot.com/10386045/diff/1/test/mjsunit/regress/r...
test/mjsunit/regress/regress-117409.js:32: // literal with a fast double
elements backing store
nit: Proper sentences with capitalization and full stop, please. (More below.)

https://chromiumcodereview.appspot.com/10386045/diff/1/test/mjsunit/regress/r...
test/mjsunit/regress/regress-117409.js:40: //   backing store will be replaces
with empty fixed array
nit: replaced

Expand Messages | Collapse Messages