Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 10386020: Revert r135533. (Closed)

Created:
8 years, 7 months ago by Nico
Modified:
8 years, 7 months ago
Reviewers:
varunjain
CC:
chromium-reviews, sadrul, yusukes+watch_chromium.org, derat+watch_chromium.org, ben+watch_chromium.org, jam, dcheng, joi+watch-content_chromium.org, darin-cc_chromium.org, jochen (gone - plz use gerrit)
Visibility:
Public.

Description

Revert r135533. It broke all content_unittests on mac in debug builds. BUG=121135, 126558 TEST=no stack dumps in content_unittests output on mac debug builds TBR=varunjain Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=135796

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -145 lines) Patch
M ash/drag_drop/drag_drop_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/test/DEPS View 1 chunk +1 line, -3 lines 0 comments Download
M content/test/content_test_suite.h View 2 chunks +1 line, -2 lines 0 comments Download
M content/test/content_test_suite.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M ui/aura/aura.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/aura/root_window_host_linux.h View 1 chunk +0 lines, -3 lines 0 comments Download
M ui/aura/root_window_host_linux.cc View 1 6 chunks +1 line, -54 lines 0 comments Download
M ui/base/x/x11_util.h View 3 chunks +0 lines, -7 lines 0 comments Download
M ui/base/x/x11_util.cc View 2 chunks +0 lines, -21 lines 0 comments Download
M ui/gfx/codec/png_codec.cc View 2 chunks +19 lines, -2 lines 0 comments Download
M ui/gfx/skia_util.h View 2 chunks +1 line, -6 lines 0 comments Download
M ui/gfx/skia_util.cc View 2 chunks +0 lines, -25 lines 0 comments Download
M ui/resources/ui_resources_2x.grd View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/resources/ui_resources_standard.grd View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/resources/ui_resources_touch.grd View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/ui.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M webkit/glue/webcursor_aurax11.cc View 2 chunks +29 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Nico
8 years, 7 months ago (2012-05-07 23:44:49 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/10386020/1
8 years, 7 months ago (2012-05-07 23:51:49 UTC) #2
commit-bot: I haz the power
Try job failure for 10386020-1 (retry) on linux_chromeos for step "compile" (clobber build). It's a ...
8 years, 7 months ago (2012-05-08 00:17:46 UTC) #3
commit-bot: I haz the power
8 years, 7 months ago (2012-05-08 00:20:59 UTC) #4

Powered by Google App Engine
This is Rietveld 408576698