Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(474)

Issue 10386014: Implement WebContentsView::GetDropData for Mac; disable on Aura (Closed)

Created:
8 years, 7 months ago by Aaron Boodman
Modified:
8 years, 7 months ago
Reviewers:
jam, sail, Evan Stade
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, dcheng
Visibility:
Public.

Description

Implement WebContentsView::GetDropData for Mac; disable on Aura I don't know what the appropriate analog is for this UI on Aura, so just disabling it now. BUG=55584 TBR=jam@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=135785

Patch Set 1 #

Total comments: 1

Patch Set 2 : crikey #

Patch Set 3 : blah #

Patch Set 4 : Revert more aura changes. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -19 lines) Patch
M chrome/browser/resources/extensions/extensions.js View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/extension_switch_utils.cc View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M content/browser/web_contents/web_contents_view_mac.mm View 1 2 3 chunks +6 lines, -1 line 0 comments Download
M content/browser/web_contents/web_drag_dest_gtk.cc View 2 chunks +3 lines, -1 line 0 comments Download
M content/browser/web_contents/web_drag_dest_mac.h View 1 2 3 chunks +8 lines, -2 lines 0 comments Download
M content/browser/web_contents/web_drag_dest_mac.mm View 1 9 chunks +22 lines, -13 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Aaron Boodman
https://chromiumcodereview.appspot.com/10386014/diff/1/content/browser/web_contents/web_drag_dest_win.cc File content/browser/web_contents/web_drag_dest_win.cc (right): https://chromiumcodereview.appspot.com/10386014/diff/1/content/browser/web_contents/web_drag_dest_win.cc#newcode209 content/browser/web_contents/web_drag_dest_win.cc:209: drop_data_.reset(); I'm not sure if this is needed, or ...
8 years, 7 months ago (2012-05-07 18:50:32 UTC) #1
Aaron Boodman
8 years, 7 months ago (2012-05-07 18:58:32 UTC) #2
Aaron Boodman
to test: 1) chrome --disable-off-store-extension-install 2) Go to www/~aa/tmp/ 3) Click blargh.crx - you should ...
8 years, 7 months ago (2012-05-07 19:04:18 UTC) #3
Aaron Boodman
Actually, use 'good.crx'. 'blargh.crx' was invalid, and I've renamed it 'bad.crx'.
8 years, 7 months ago (2012-05-07 19:07:36 UTC) #4
Aaron Boodman
estade: extensions.js sail: actually review jam: rubber-stamp content/browser
8 years, 7 months ago (2012-05-07 21:18:10 UTC) #5
sail
cocoa/* LGTM!
8 years, 7 months ago (2012-05-07 21:52:42 UTC) #6
Evan Stade
lgtm
8 years, 7 months ago (2012-05-07 22:00:15 UTC) #7
Matt Perry
8 years, 7 months ago (2012-05-08 00:27:43 UTC) #8
On 2012/05/07 19:07:36, Aaron Boodman wrote:
> Actually, use 'good.crx'. 'blargh.crx' was invalid, and I've renamed it
> 'bad.crx'.

I finally got a Windows build working to test this. Steps 1-6 work, 7 does not.
I see these errors:

[6196:7960:19898301:ERROR:install_extension_handler.cc(57)] No current drop
data.
[6196:7960:19899721:ERROR:install_extension_handler.cc(76)] No file captured to
install.

The first when I hover the file over the page, the second when I release the
mouse button. The drag UI disappears and nothing happens.

Powered by Google App Engine
This is Rietveld 408576698