Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Unified Diff: ash/wm/base_layout_manager.cc

Issue 10384212: fix property linkage warnings (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ash/wm/property_util.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/wm/base_layout_manager.cc
diff --git a/ash/wm/base_layout_manager.cc b/ash/wm/base_layout_manager.cc
index e9510c939dd6b99b60b47c0a759d68f843538aa5..4f27115e81e160c7d72b3e301e51e1f00858583a 100644
--- a/ash/wm/base_layout_manager.cc
+++ b/ash/wm/base_layout_manager.cc
@@ -6,20 +6,17 @@
#include "ash/screen_ash.h"
#include "ash/shell.h"
-#include "ash/wm/property_util.h"
#include "ash/wm/shelf_layout_manager.h"
#include "ash/wm/window_animations.h"
+#include "ash/wm/window_properties.h"
#include "ash/wm/window_util.h"
#include "ui/aura/client/aura_constants.h"
#include "ui/aura/root_window.h"
#include "ui/aura/window.h"
-#include "ui/aura/window_property.h"
#include "ui/base/ui_base_types.h"
#include "ui/compositor/layer.h"
#include "ui/gfx/screen.h"
-DECLARE_WINDOW_PROPERTY_TYPE(ui::WindowShowState)
-
namespace {
// Given a |window| and tentative |restore_bounds|, returns new bounds that
@@ -41,10 +38,6 @@ gfx::Rect BoundsWithScreenEdgeVisible(aura::Window* window,
return restore_bounds;
}
-// Used to remember the show state before the window was minimized.
-DEFINE_WINDOW_PROPERTY_KEY(
- ui::WindowShowState, kRestoreShowStateKey, ui::SHOW_STATE_DEFAULT);
-
} // namespace
namespace ash {
@@ -98,8 +91,8 @@ void BaseLayoutManager::OnChildWindowVisibilityChanged(aura::Window* child,
if (visible && wm::IsWindowMinimized(child)) {
// Attempting to show a minimized window. Unminimize it.
child->SetProperty(aura::client::kShowStateKey,
- child->GetProperty(kRestoreShowStateKey));
- child->ClearProperty(kRestoreShowStateKey);
+ child->GetProperty(internal::kRestoreShowStateKey));
+ child->ClearProperty(internal::kRestoreShowStateKey);
}
}
@@ -156,7 +149,7 @@ void BaseLayoutManager::ShowStateChanged(aura::Window* window,
ui::WindowShowState last_show_state) {
if (wm::IsWindowMinimized(window)) {
// Save the previous show state so that we can correctly restore it.
- window->SetProperty(kRestoreShowStateKey, last_show_state);
+ window->SetProperty(internal::kRestoreShowStateKey, last_show_state);
SetWindowVisibilityAnimationType(
window, WINDOW_VISIBILITY_ANIMATION_TYPE_MINIMIZE);
« no previous file with comments | « no previous file | ash/wm/property_util.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698