Issue 10384212: fix property linkage warnings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10384212: fix property linkage warnings (Closed)

Created:
8 years, 7 months ago by oshima

Modified:
8 years, 7 months ago

Reviewers:
sky

CC:
chromium-reviews, sadrul, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

fix property linkage warnings - move property definitions to window_properties - removed unused kOpenWindowSplitKey BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=137633

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+51 lines, -64 lines)			Patch
M	ash/wm/base_layout_manager.cc	View		4 chunks	+4 lines, -11 lines	0 comments	Download
M	ash/wm/property_util.h	View		2 chunks	+0 lines, -9 lines	0 comments	Download
M	ash/wm/property_util.cc	View		2 chunks	+8 lines, -24 lines	0 comments	Download
M	ash/wm/visibility_controller.cc	View		1 chunk	+5 lines, -12 lines	0 comments	Download
M	ash/wm/window_properties.h	View	1	2 chunks	+18 lines, -0 lines	0 comments	Download
M	ash/wm/window_properties.cc	View	1	1 chunk	+13 lines, -0 lines	0 comments	Download
M	ash/wm/window_util.cc	View		1 chunk	+1 line, -5 lines	0 comments	Download
M	ash/wm/workspace/workspace_layout_manager.cc	View		3 chunks	+2 lines, -3 lines	0 comments	Download

Total messages: 4 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/10384212/10

8 years, 7 months ago (2012-05-17 04:08:44 UTC) #3

Change committed as 137633