Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(741)

Issue 10384211: Add SSlHostState::Clear() (Closed)

Created:
8 years, 7 months ago by Jesse Greenwald
Modified:
8 years, 5 months ago
Reviewers:
abarth-chromium
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, jochen+watch-content_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Add SSlHostState::Clear() This method is used by Chrome on Android. It allows SSL warnings to be reset so that SSL error prompts will start getting displayed against even if the user previously clicked through the warning page. BUG=115372 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=144340

Patch Set 1 #

Patch Set 2 : Remove #ifdef's, add test code #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -0 lines) Patch
M content/browser/ssl/ssl_host_state.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M content/browser/ssl/ssl_host_state.cc View 1 1 chunk +6 lines, -0 lines 0 comments Download
M content/browser/ssl/ssl_host_state_unittest.cc View 1 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Jesse Greenwald
abarth - can you review this change? thanks,
8 years, 7 months ago (2012-05-16 22:45:57 UTC) #1
abarth-chromium
This is fine, but please remove the OS(ANDROID) ifdefs. Nothing about this code is specific ...
8 years, 7 months ago (2012-05-17 02:07:20 UTC) #2
Jesse Greenwald
Addressed comments - PTAL thanks,
8 years, 6 months ago (2012-05-31 20:51:52 UTC) #3
Jesse Greenwald
On 2012/05/17 02:07:20, abarth wrote: > This is fine, but please remove the OS(ANDROID) ifdefs. ...
8 years, 6 months ago (2012-06-15 21:46:39 UTC) #4
abarth-chromium
lgtm
8 years, 6 months ago (2012-06-15 21:50:05 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jgreenwald@chromium.org/10384211/4001
8 years, 6 months ago (2012-06-26 22:22:45 UTC) #6
commit-bot: I haz the power
Try job failure for 10384211-4001 on win for step "update". http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number=17406 Step "update" is always ...
8 years, 6 months ago (2012-06-26 22:53:57 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jgreenwald@chromium.org/10384211/4001
8 years, 6 months ago (2012-06-26 23:07:29 UTC) #8
commit-bot: I haz the power
8 years, 5 months ago (2012-06-27 00:42:04 UTC) #9
Change committed as 144340

Powered by Google App Engine
This is Rietveld 408576698