Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 10384204: gdata: Fix a bug that caused google drive not to load (Closed)

Created:
8 years, 7 months ago by satorux1
Modified:
8 years, 7 months ago
Reviewers:
achuithb
CC:
chromium-reviews, achuith+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

gdata: Fix a bug that caused google drive not to load There were two subtle changes in how we stored the file system metadata in a proto file, and each change broke compatibility in a subtle way. We should discard the proto file if old formats are detected. Note that the protobuf definitions in gdata.proto were kept compatible. The problem was in how we stored data in the protobuf, and the changes were subtle. BUG=128133 TEST=confirmed that the google drive loaded with the stale GCache directory from josh Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=137492

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix DCHECK failure in test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -0 lines) Patch
M chrome/browser/chromeos/gdata/gdata_files.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/gdata/gdata_files_unittest.cc View 1 2 chunks +34 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
satorux1
8 years, 7 months ago (2012-05-16 17:09:49 UTC) #1
achuithb
http://codereview.chromium.org/10384204/diff/1/chrome/browser/chromeos/gdata/gdata_files.cc File chrome/browser/chromeos/gdata/gdata_files.cc (right): http://codereview.chromium.org/10384204/diff/1/chrome/browser/chromeos/gdata/gdata_files.cc#newcode869 chrome/browser/chromeos/gdata/gdata_files.cc:869: // The title field for the root directory was ...
8 years, 7 months ago (2012-05-16 18:25:16 UTC) #2
satorux1
http://codereview.chromium.org/10384204/diff/1/chrome/browser/chromeos/gdata/gdata_files.cc File chrome/browser/chromeos/gdata/gdata_files.cc (right): http://codereview.chromium.org/10384204/diff/1/chrome/browser/chromeos/gdata/gdata_files.cc#newcode869 chrome/browser/chromeos/gdata/gdata_files.cc:869: // The title field for the root directory was ...
8 years, 7 months ago (2012-05-16 18:28:14 UTC) #3
achuithb
lgtm
8 years, 7 months ago (2012-05-16 18:31:36 UTC) #4
achuithb
8 years, 7 months ago (2012-05-16 18:32:13 UTC) #5
On 2012/05/16 18:31:36, achuith.bhandarkar wrote:
> lgtm

Thanks for the fix. I think I inadvertently introduced the bug.

Powered by Google App Engine
This is Rietveld 408576698