Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Unified Diff: chrome/browser/search_engines/template_url_service.h

Issue 10384188: Ensure that TemplateURLs removed by prepopulate search engine merging is also removed from Sync. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: removed AddPreSyncDeletedGUIDForTesting; test empty set; merge to TOT Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/search_engines/template_url_service.h
diff --git a/chrome/browser/search_engines/template_url_service.h b/chrome/browser/search_engines/template_url_service.h
index 39519b3580847a180ae50aabf068c0ad8ebdfb62..96338c600330250b1548dd87e8a2a087e50aeee2 100644
--- a/chrome/browser/search_engines/template_url_service.h
+++ b/chrome/browser/search_engines/template_url_service.h
@@ -354,6 +354,8 @@ class TemplateURLService : public WebDataServiceConsumer,
FindDuplicateOfSyncTemplateURL);
FRIEND_TEST_ALL_PREFIXES(TemplateURLServiceSyncTest,
MergeSyncAndLocalURLDuplicates);
+ FRIEND_TEST_ALL_PREFIXES(TemplateURLServiceSyncTest,
+ PreSyncDeletes);
friend class TemplateURLServiceTestUtil;
@@ -628,6 +630,12 @@ class TemplateURLService : public WebDataServiceConsumer,
// the Synced default when the default search provider becomes unmanaged.
bool pending_synced_default_search_;
+ // A set of sync GUIDs denoting TemplateURLs that have been removed from this
+ // model or the underlying WebDataService prior to MergeDataAndStartSyncing.
+ // This set is used to determine what entries from the server we want to
+ // ignore locally and return a delete command for.
+ std::set<std::string> pre_sync_deletes_;
+
DISALLOW_COPY_AND_ASSIGN(TemplateURLService);
};
« no previous file with comments | « chrome/browser/search_engines/search_provider_install_data.cc ('k') | chrome/browser/search_engines/template_url_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698