Reduced 'Paste cancelled' butter exposition time.

chrome/browser/resources/file_manager/js/file_manager.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * FileManager constructor.
  *
  * FileManager objects encapsulate the functionality of the file selector
  * dialogs, as well as the full screen file manager application (though the
  * latter is not yet implemented).
@@ skipping 875 matching lines @@
         actions.classList.remove('hide-in-butter');
       }
       if ('progress' in opt_options) {
         butter.querySelector('.progress-bar')
             .classList.remove('hide-in-butter');
       }
     }
 
     var self = this;
 
     setTimeout(function() {

[Oleg Eterevsky, 2012/05/15 09:39:40]

Missing the timeout in this call? I don't see where opt_options.timeout is used
in this method.

[SeRya, 2012/05/15 10:06:50]

opt_options is passed further.

On 2012/05/15 09:39:40, Oleg wrote:

       self.currentButter_ = butter;
       self.updateButter(message, opt_options);
       self.butterLastShowTime_ = new Date();
     });
 
     return butter;
   };
 
   FileManager.prototype.showButterError = function(message, opt_options) {
     var butter = this.showButter(message, opt_options);
@@ skipping 350 matching lines @@
                 strf('PASTE_FILESYSTEM_ERROR',
                       getFileErrorString(event.error.data.code)));
           }
           break;
 
         default:
           this.showButterError(strf('PASTE_UNEXPECTED_ERROR', event.error));
           break;
       }
     } else if (event.reason == 'CANCELLED') {
-      this.showButter(str('PASTE_CANCELLED'));
+      this.showButter(str('PASTE_CANCELLED'), { timeout: 1000 });

[Oleg Eterevsky, 2012/05/15 09:39:40]

I suspect it should be formatted as follows:

{'timeout': 1000}

(Quotes & no spaces inside braces.)

[SeRya, 2012/05/15 10:06:50]

Quotas are not needed:
http://google-styleguide.googlecode.com/svn/trunk/javascriptguide.xml?showone...

On 2012/05/15 09:39:40, Oleg wrote:

     } else {
       console.log('Unknown event reason: ' + event.reason);
     }
 
     // TODO(benchan): Currently, there is no FileWatcher emulation for
     // GDataFileSystem, so we need to manually trigger the directory rescan
     // after paste operations complete. Remove this once we emulate file
     // watching functionalities in GDataFileSystem.
     if (this.isOnGData()) {
       if (event.reason == 'SUCCESS' || event.reason == 'ERROR' ||
@@ skipping 3201 matching lines @@
 
     this.directoryModel_.addEventListener('scan-completed', maybeShowBanner);
     this.directoryModel_.addEventListener('rescan-completed', maybeShowBanner);
 
     var style = this.document_.createElement('link');
     style.rel = 'stylesheet';
     style.href = 'css/gdrive_welcome.css';
     this.document_.head.appendChild(style);
   };
 })();