Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(700)

Unified Diff: remoting/client/plugin/pepper_port_allocator.h

Issue 10384171: Fix PepperPortAllocator to resolve STUN addresses using HostResolverPrivate. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/client/plugin/pepper_port_allocator.h
diff --git a/remoting/client/plugin/pepper_port_allocator.h b/remoting/client/plugin/pepper_port_allocator.h
index 214cea53dc1e2c533c0e9b6edb673292168b50cd..c9a5dbde0658d08e8cf87e2e7a4eff792dc32f2a 100644
--- a/remoting/client/plugin/pepper_port_allocator.h
+++ b/remoting/client/plugin/pepper_port_allocator.h
@@ -13,9 +13,14 @@
namespace remoting {
// An implementation of cricket::PortAllocator for libjingle that is
-// used by the client plugin. The main difference from
-// cricket::HttpPortAllocator is that it uses Pepper URLLoader API
-// when creating relay sessions.
+// used by the client plugin. There are two differences from
+// cricket::HttpPortAllocator:
+// * PepperPortAllocator uses Pepper URLLoader API when creating
+// relay sessions.
+// * PepperPortAllocator resolves STUN DNS names and passes IP
+// addresses to BasicPortAllocator (it uses HostResolverPrivate API
+// for that). This is needed because libjingle's DNS resolution
+// code doesn't work in sandbox.
class PepperPortAllocator : public cricket::HttpPortAllocatorBase {
public:
static scoped_ptr<PepperPortAllocator> Create(
« no previous file with comments | « remoting/client/plugin/pepper_packet_socket_factory.cc ('k') | remoting/client/plugin/pepper_port_allocator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698