Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 10384160: Merge 116722 - Sync with impl thread when removing references to external textures (Closed)

Created:
8 years, 7 months ago by piman
Modified:
8 years, 7 months ago
Reviewers:
piman
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1132/
Visibility:
Public.

Description

Merge 116722 - Sync with impl thread when removing references to external textures https://bugs.webkit.org/show_bug.cgi?id=86054 We want to ensure the client side is safe to release textures, so we sync with the impl thread when: - we change the texture (and we had one) - the layer is removed from the tree (and we had a texture) - the layer is destroyed (and we had a texture) Reviewed by James Robinson. Test: TextureLayerChromiumTest. * platform/graphics/chromium/TextureLayerChromium.cpp: (WebCore::TextureLayerChromium::~TextureLayerChromium): (WebCore::TextureLayerChromium::setTextureId): (WebCore::TextureLayerChromium::setLayerTreeHost): (WebCore): * platform/graphics/chromium/TextureLayerChromium.h: (TextureLayerChromium): TBR=piman@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=116982

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -2 lines) Patch
M Source/WebCore/platform/graphics/chromium/TextureLayerChromium.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/WebCore/platform/graphics/chromium/TextureLayerChromium.cpp View 3 chunks +17 lines, -2 lines 0 comments Download
M Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/WebKit/chromium/WebKit.gypi View 1 chunk +1 line, -0 lines 0 comments Download
A + Source/WebKit/chromium/tests/TextureLayerChromiumTest.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
piman
8 years, 7 months ago (2012-05-14 19:18:00 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698