Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 10384149: Refactor Date. (Closed)

Created:
8 years, 7 months ago by floitsch
Modified:
6 years, 10 months ago
Reviewers:
Sean Eagan
CC:
reviews_dartlang.org, Sean Eagan
Visibility:
Public.

Description

Refactor Date.

Patch Set 1 #

Patch Set 2 : Make month and day optional. #

Patch Set 3 : Add comparison operators. #

Total comments: 9

Patch Set 4 : Address comments. #

Patch Set 5 : Remove daylightsaving predicate. #

Patch Set 6 : rebase #

Patch Set 7 : Rename localTimeZone to timeZoneName #

Patch Set 8 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -60 lines) Patch
M corelib/src/date.dart View 1 2 3 4 5 6 7 5 chunks +29 lines, -46 lines 0 comments Download
D corelib/src/time_zone.dart View 1 chunk +0 lines, -14 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Sean Eagan
LGTM (I always wanted to do that ;) ) with comments https://chromiumcodereview.appspot.com/10384149/diff/4001/corelib/src/date.dart File corelib/src/date.dart (right): ...
8 years, 7 months ago (2012-05-14 14:43:51 UTC) #1
floitsch
Thanks for the comments. https://chromiumcodereview.appspot.com/10384149/diff/4001/corelib/src/date.dart File corelib/src/date.dart (right): https://chromiumcodereview.appspot.com/10384149/diff/4001/corelib/src/date.dart#newcode19 corelib/src/date.dart:19: int get timeZoneOffsetInMinutes() On 2012/05/14 ...
8 years, 7 months ago (2012-05-14 15:01:16 UTC) #2
floitsch
8 years, 7 months ago (2012-05-14 15:02:57 UTC) #3
floitsch
CL implementing Hashable. https://chromiumcodereview.appspot.com/10391109/
8 years, 7 months ago (2012-05-14 15:35:16 UTC) #4
Sean Eagan
https://chromiumcodereview.appspot.com/10384149/diff/4001/corelib/src/date.dart File corelib/src/date.dart (right): https://chromiumcodereview.appspot.com/10384149/diff/4001/corelib/src/date.dart#newcode22 corelib/src/date.dart:22: bool get summerTimeSavingsIsActive() On 2012/05/14 15:01:16, floitsch wrote: > ...
8 years, 7 months ago (2012-05-14 16:05:16 UTC) #5
floitsch
https://chromiumcodereview.appspot.com/10384149/diff/4001/corelib/src/date.dart File corelib/src/date.dart (right): https://chromiumcodereview.appspot.com/10384149/diff/4001/corelib/src/date.dart#newcode22 corelib/src/date.dart:22: bool get summerTimeSavingsIsActive() On 2012/05/14 16:05:16, seaneagan1 wrote: > ...
8 years, 7 months ago (2012-05-14 16:12:11 UTC) #6
floitsch
8 years, 7 months ago (2012-05-15 13:14:20 UTC) #7

Powered by Google App Engine
This is Rietveld 408576698