Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(526)

Unified Diff: editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/actions/RefactorActionGroup.java

Issue 10384142: Initial support for 'Extract temp' - only when single expression selected (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Use ASTVisitor as type switch Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/actions/RefactorActionGroup.java
diff --git a/editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/actions/RefactorActionGroup.java b/editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/actions/RefactorActionGroup.java
index 34bd087aa722d59e47f5e609a8eebb512531add9..1f45e0738ecd78bcb4a3849c6ec1315aa9ef76ae 100644
--- a/editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/actions/RefactorActionGroup.java
+++ b/editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/actions/RefactorActionGroup.java
@@ -135,7 +135,7 @@ public class RefactorActionGroup extends ActionGroup {
// //private SelectionDispatchAction fReplaceInvocationsAction;
// private SelectionDispatchAction fIntroduceIndirectionAction;
// private SelectionDispatchAction fExtractMethodAction;
-// private SelectionDispatchAction fExtractTempAction;
+ private SelectionDispatchAction fExtractLocalAction;
// private SelectionDispatchAction fExtractConstantAction;
// private SelectionDispatchAction fExtractClassAction;
// private SelectionDispatchAction fIntroduceParameterAction;
@@ -182,6 +182,15 @@ public class RefactorActionGroup extends ActionGroup {
initAction(fRenameAction, selection, DartEditorActionDefinitionIds.RENAME_ELEMENT);
editor.setAction("RenameElement", fRenameAction); //$NON-NLS-1$
+ fExtractLocalAction = new ExtractLocalAction(editor);
+ initUpdatingAction(
+ fExtractLocalAction,
+ provider,
+ null,
+ selection,
+ DartEditorActionDefinitionIds.EXTRACT_LOCAL_VARIABLE);
+ editor.setAction("ExtractLocalVariable", fExtractLocalAction); //$NON-NLS-1$
+
// fMoveAction= new MoveAction(editor);
// initAction(fMoveAction, selection, IJavaEditorActionDefinitionIds.MOVE_ELEMENT);
// editor.setAction("MoveElement", fMoveAction); //$NON-NLS-1$
@@ -230,10 +239,6 @@ public class RefactorActionGroup extends ActionGroup {
// initUpdatingAction(fExtractMethodAction, provider, null, selection, IJavaEditorActionDefinitionIds.EXTRACT_METHOD);
// editor.setAction("ExtractMethod", fExtractMethodAction); //$NON-NLS-1$
//
-// fExtractTempAction= new ExtractTempAction(editor);
-// initUpdatingAction(fExtractTempAction, provider, null, selection, IJavaEditorActionDefinitionIds.EXTRACT_LOCAL_VARIABLE);
-// editor.setAction("ExtractLocalVariable", fExtractTempAction); //$NON-NLS-1$
-//
// fExtractConstantAction= new ExtractConstantAction(editor);
// initUpdatingAction(fExtractConstantAction, provider, null, selection, IJavaEditorActionDefinitionIds.EXTRACT_CONSTANT);
// editor.setAction("ExtractConstant", fExtractConstantAction); //$NON-NLS-1$
@@ -395,7 +400,7 @@ public class RefactorActionGroup extends ActionGroup {
// disposeAction(fModifyParametersAction, fSelectionProvider);
// disposeAction(fPullUpAction, fSelectionProvider);
// disposeAction(fPushDownAction, fSelectionProvider);
-// disposeAction(fExtractTempAction, fSelectionProvider);
+ disposeAction(fExtractLocalAction, fSelectionProvider);
// disposeAction(fExtractConstantAction, fSelectionProvider);
// disposeAction(fIntroduceParameterAction, fSelectionProvider);
// disposeAction(fIntroduceParameterObjectAction, fSelectionProvider);
@@ -431,7 +436,7 @@ public class RefactorActionGroup extends ActionGroup {
// actionBars.setGlobalActionHandler(JdtActionConstants.MODIFY_PARAMETERS, fModifyParametersAction);
// actionBars.setGlobalActionHandler(JdtActionConstants.PULL_UP, fPullUpAction);
// actionBars.setGlobalActionHandler(JdtActionConstants.PUSH_DOWN, fPushDownAction);
-// actionBars.setGlobalActionHandler(JdtActionConstants.EXTRACT_TEMP, fExtractTempAction);
+ actionBars.setGlobalActionHandler(JdtActionConstants.EXTRACT_LOCAL, fExtractLocalAction);
// actionBars.setGlobalActionHandler(JdtActionConstants.EXTRACT_CONSTANT, fExtractConstantAction);
// actionBars.setGlobalActionHandler(JdtActionConstants.INTRODUCE_PARAMETER, fIntroduceParameterAction);
// actionBars.setGlobalActionHandler(JdtActionConstants.INTRODUCE_FACTORY, fIntroduceFactoryAction);
@@ -557,12 +562,13 @@ public class RefactorActionGroup extends ActionGroup {
new GroupMarker(fGroupName));
refactorSubmenu.appendToGroup(fGroupName, new Separator(GROUP_REORG));
added += addAction(refactorSubmenu, GROUP_REORG, fRenameAction);
+ added += addAction(refactorSubmenu, GROUP_REORG, fExtractLocalAction);
// added += addAction(refactorSubmenu, fMoveAction);
refactorSubmenu.add(new Separator(GROUP_CODING));
// added += addAction(refactorSubmenu, fModifyParametersAction);
// added += addAction(refactorSubmenu, fExtractMethodAction);
-// added += addAction(refactorSubmenu, fExtractTempAction);
+// added += addAction(refactorSubmenu, fExtractLocalAction);
// added += addAction(refactorSubmenu, fExtractConstantAction);
// added += addAction(refactorSubmenu, fInlineAction);

Powered by Google App Engine
This is Rietveld 408576698